From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752977AbcJLFuk (ORCPT ); Wed, 12 Oct 2016 01:50:40 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36706 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbcJLFuf (ORCPT ); Wed, 12 Oct 2016 01:50:35 -0400 Date: Wed, 12 Oct 2016 01:50:22 -0400 (EDT) Message-Id: <20161012.015022.2273537782016406180.davem@davemloft.net> To: gorcunov@gmail.com Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, jhs@mojatatu.com, dsa@cumulusnetworks.com, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, avagin@openvz.org, stephen@networkplumber.org Subject: Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets From: David Miller In-Reply-To: <20161006100055.GA1941@uranus.lan> References: <20161006100055.GA1941@uranus.lan> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 11 Oct 2016 22:50:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cyrill Gorcunov Date: Thu, 6 Oct 2016 13:00:55 +0300 > v6: > - use sdiag_raw_protocol() helper which will access @pad > structure used for raw sockets protocol specification: > we can't simply rename this member without breaking uapi. Macros that look like function calls and are also lvalues tend to be troublesome. I know what you're trying to achieve, you want a named way to access this so that the intent and semantics are clear. But I'd rather you do something that provides a way by which normal struct member accesses do the job, and your earlier patches achieved this.