From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753192AbcJLGCz (ORCPT ); Wed, 12 Oct 2016 02:02:55 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36808 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbcJLGCv (ORCPT ); Wed, 12 Oct 2016 02:02:51 -0400 Date: Wed, 12 Oct 2016 01:52:32 -0400 (EDT) Message-Id: <20161012.015232.757833208470209652.davem@davemloft.net> To: geert@linux-m68k.org Cc: tom@herbertland.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] strparser: Propagate correct error code in strp_recv() From: David Miller In-Reply-To: <1475761309-13481-1-git-send-email-geert@linux-m68k.org> References: <1475761309-13481-1-git-send-email-geert@linux-m68k.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 11 Oct 2016 22:52:34 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9C637v4010987 From: Geert Uytterhoeven Date: Thu, 6 Oct 2016 15:41:49 +0200 > With m68k-linux-gnu-gcc-4.1: > > net/strparser/strparser.c: In function ˇstrp_recv˘: > net/strparser/strparser.c:98: warning: ˇerr˘ may be used uninitialized in this function > > Pass "len" (which is an error code when negative) instead of the > uninitialized "err" variable to fix this. > > Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages") > Signed-off-by: Geert Uytterhoeven Applied and queued up for -stable, thanks.