From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754090AbcJLHGe (ORCPT ); Wed, 12 Oct 2016 03:06:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:42339 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752980AbcJLHG0 (ORCPT ); Wed, 12 Oct 2016 03:06:26 -0400 Date: Wed, 12 Oct 2016 09:06:17 +0200 From: Johannes Thumshirn To: Christoph Hellwig Cc: "Martin K . Petersen" , Hannes Reinecke , Linux Kernel Mailinglist , Linux SCSI Mailinglist Subject: Re: [PATCH 00/44] Convert FibreChannel bsg code to use bsg-lib Message-ID: <20161012070609.42s2z3fs3yz57m3s@linux-x5ow.site> References: <20161011164938.GA6083@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161011164938.GA6083@infradead.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 11, 2016 at 09:49:38AM -0700, Christoph Hellwig wrote: > Hi Johannes, > > this looks great to me. But is there a chance to consolidate it into > a more manageable set of patches? E.g. all the patches to call > export fc_bsg_jobdone, use it directly and remove the function pointer > could go together, possibly even including the new calling convention. > Similar all the patches about fc_bsg_to_shost could be merged into one, > and if we add the bsg refcounting early, we could maybe skip a few > steps of the conversion later on? Sure, I think 44 patches is a bit huge. Especially given the 0day bot fallout it generated. Let me see how I can slim it down. Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850