From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932804AbcJLKcS (ORCPT ); Wed, 12 Oct 2016 06:32:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:47413 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932395AbcJLKcL (ORCPT ); Wed, 12 Oct 2016 06:32:11 -0400 Date: Wed, 12 Oct 2016 12:32:04 +0200 From: Borislav Petkov To: Grzegorz Andrejczuk Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org, lukasz.daniluk@intel.com, james.h.cownie@intel.com Subject: Re: [PATCH v1 4/4] Add R3MWAIT to CPU features Message-ID: <20161012103204.GA3535@nazgul.tnic> References: <1476267190-2303-1-git-send-email-grzegorz.andrejczuk@intel.com> <1476267190-2303-5-git-send-email-grzegorz.andrejczuk@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1476267190-2303-5-git-send-email-grzegorz.andrejczuk@intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2016 at 12:13:10PM +0200, Grzegorz Andrejczuk wrote: > Add cpu feature for ring 3 monitor/mwait. > > Change-Id: Iba4d20639efd8d3637d37db9294cbc43a98f009a Please no internal IDs in upstream submission. > Signed-off-by: Grzegorz Andrejczuk ... > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h > index 92a8308..242cd16 100644 > --- a/arch/x86/include/asm/cpufeatures.h > +++ b/arch/x86/include/asm/cpufeatures.h > @@ -12,7 +12,7 @@ > /* > * Defines x86 CPU feature bits > */ > -#define NCAPINTS 18 /* N 32-bit words worth of info */ > +#define NCAPINTS 19 /* N 32-bit words worth of info */ > #define NBUGINTS 1 /* N 32-bit bug flags */ > > /* > @@ -286,6 +286,10 @@ > #define X86_FEATURE_SUCCOR (17*32+1) /* Uncorrectable error containment and recovery */ > #define X86_FEATURE_SMCA (17*32+3) /* Scalable MCA */ > > + > +/* non architectural Intel-defined CPU features not present in CPUID, word 18 */ > +#define X86_FEATURE_PHIR3MWAIT (18*32+ 0) Please use init_scattered_cpuid_features() for the whole thing. There are some free bits in word 3 for example, see arch/x86/include/asm/cpufeatures.h. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --