From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933422AbcJMAmo (ORCPT ); Wed, 12 Oct 2016 20:42:44 -0400 Received: from imap.thunk.org ([74.207.234.97]:56046 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752237AbcJMAmk (ORCPT ); Wed, 12 Oct 2016 20:42:40 -0400 Date: Wed, 12 Oct 2016 18:13:28 -0400 From: "Theodore Ts'o" To: Joe Perches Cc: Jan Kara , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: super.c: Update logging style using PR_CONT Message-ID: <20161012221328.pkglnedwbkigtrko@thunk.org> Mail-Followup-To: Theodore Ts'o , Joe Perches , Jan Kara , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <20161012104157.GB14664@quack2.suse.cz> <1476282730.16823.7.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476282730.16823.7.camel@perches.com> User-Agent: NeoMutt/20160916 (1.7.0) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2016 at 07:32:10AM -0700, Joe Perches wrote: > On Wed, 2016-10-12 at 12:41 +0200, Jan Kara wrote: > > On Tue 11-10-16 18:57:58, Joe Perches wrote: > > > Recent commit require line continuing printks to use PR_CONT. > > > > > > Update super.c to use PR_CONT and use vsprintf extension %pV > > > to avoid a printk/vprintk/printk("\n") sequence as well. > > > > > > Looks good. You can add: > > > > Reviewed-by: Jan Kara > > Except the subject and commit bodyis broken and should use KERN_CONT not PR_CONT > > Ted, can you please fix when applying or do you want a resubmit? I'll fix it up, no worries!. - Ted