From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755951AbcJMPNg (ORCPT ); Thu, 13 Oct 2016 11:13:36 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34014 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752675AbcJMPN0 (ORCPT ); Thu, 13 Oct 2016 11:13:26 -0400 Date: Thu, 13 Oct 2016 11:02:44 -0400 (EDT) Message-Id: <20161013.110244.359940583425366977.davem@davemloft.net> To: arnd@arndb.de Cc: wei.liu2@citrix.com, paul.durrant@citrix.com, david.vrabel@citrix.com, xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen-netback: fix type mismatch warning From: David Miller In-Reply-To: <20161012145434.2493788-1-arnd@arndb.de> References: <20161012145434.2493788-1-arnd@arndb.de> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 13 Oct 2016 08:02:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Wed, 12 Oct 2016 16:54:01 +0200 > Wiht the latest rework of the xen-netback driver, we get a warning > on ARM about the types passed into min(): > > drivers/net/xen-netback/rx.c: In function 'xenvif_rx_next_chunk': > include/linux/kernel.h:739:16: error: comparison of distinct pointer types lacks a cast [-Werror] > > The reason is that XEN_PAGE_SIZE is not size_t here. There > is no actual bug, and we can easily avoid the warning using the > min_t() macro instead of min(). > > Fixes: eb1723a29b9a ("xen-netback: refactor guest rx") > Signed-off-by: Arnd Bergmann Applied, thanks.