From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756694AbcJMQII (ORCPT ); Thu, 13 Oct 2016 12:08:08 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:34794 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756658AbcJMQHx (ORCPT ); Thu, 13 Oct 2016 12:07:53 -0400 Date: Thu, 13 Oct 2016 11:59:56 -0400 (EDT) Message-Id: <20161013.115956.2197317299874950600.davem@davemloft.net> To: zach.brown@ni.com Cc: f.fainelli@gmail.com, mlindner@marvell.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, rpurdie@rpsys.net, j.anaszewski@samsung.com, linux-leds@vger.kernel.org, andrew@lunn.ch Subject: Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change From: David Miller In-Reply-To: <20161013154246.GA17387@zach-desktop> References: <1476217580-21229-4-git-send-email-zach.brown@ni.com> <20161013.104634.2079376697690971907.davem@davemloft.net> <20161013154246.GA17387@zach-desktop> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 13 Oct 2016 08:59:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zach Brown Date: Thu, 13 Oct 2016 10:42:46 -0500 > Do you have suggestions on how to better handle the choice of the array size > and the speeds? All of the speed values are simply the rate in bits per second. There is therefore no reason you can't just print the raw value and scale it to whatever is appropriate ("MB/s", "GB/s", etc.)