From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Taesoo Kim <tsgatesv@gmail.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu,
blee@gatech.edu, csong84@gatech.edu, stable@vger.kernel.org,
"Faccini, Bruno" <bruno.faccini@intel.com>
Subject: Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock
Date: Wed, 12 Oct 2016 23:21:13 -0400 [thread overview]
Message-ID: <20161013032112.iy4hohrqplsajtye@thunk.org> (raw)
In-Reply-To: <FB6D02AD-62D8-4D29-81DF-B8BF81BD5FAC@dilger.ca>
On Wed, Oct 12, 2016 at 04:58:35PM -0600, Andreas Dilger wrote:
> On Mar 17, 2015, at 8:08 PM, Taesoo Kim <tsgatesv@gmail.com> wrote:
> >
> > When 'jh->b_transaction == transaction' (asserted by below)
> >
> > J_ASSERT_JH(jh, (jh->b_transaction == transaction || ...
> >
> > 'journal->j_list_lock' will be incorrectly unlocked, since
> > spin_lock() is called only in the 'if' and 'else-if' blocks but
> > not in the missing 'else' case, which results in a hang or an oops....
> >
> > Signed-off-by: Taesoo Kim <tsgatesv@gmail.com>
>
> We've hit this repeatedly on kernels with commit v3.14-rc2-30-g6e4862a
> "jbd2: minimize region locked by j_list_lock in journal_get_create_access"
> under heavy load and this patch has fixed the problem.
>
> It should also be considered for stable kernels after 3.14.
>
> [I've updated the above commit message slightly to give more details.]
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
Apologies, this got lost which is why I hadn't handled it earlier.
- Ted
prev parent reply other threads:[~2016-10-13 3:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 2:08 Taesoo Kim
2015-03-18 10:43 ` Lukáš Czerner
2015-03-18 17:39 ` Taesoo Kim
2015-03-19 9:48 ` Lukáš Czerner
2015-03-19 12:02 ` Taesoo Kim
2015-03-19 12:13 ` Lukáš Czerner
2016-10-12 22:58 ` Andreas Dilger
2016-10-13 3:21 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013032112.iy4hohrqplsajtye@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=blee@gatech.edu \
--cc=bruno.faccini@intel.com \
--cc=changwoo@gatech.edu \
--cc=csong84@gatech.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanidhya@gatech.edu \
--cc=stable@vger.kernel.org \
--cc=taesoo@gatech.edu \
--cc=tsgatesv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®