From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755425AbcJMGXV (ORCPT ); Thu, 13 Oct 2016 02:23:21 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:35516 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754839AbcJMGXO (ORCPT ); Thu, 13 Oct 2016 02:23:14 -0400 Date: Thu, 13 Oct 2016 08:22:38 +0200 From: Michal Hocko To: Vlastimil Babka Cc: Andrew Morton , Mel Gorman , Joonsoo Kim , Dave Chinner , linux-mm@kvack.org, LKML Subject: Re: [PATCH] mm, compaction: allow compaction for GFP_NOFS requests Message-ID: <20161013062238.GA21678@dhcp22.suse.cz> References: <20161012114721.31853-1-mhocko@kernel.org> <224e7340-411c-f0ea-a9b5-0191517fbf7d@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <224e7340-411c-f0ea-a9b5-0191517fbf7d@suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 13-10-16 08:19:53, Vlastimil Babka wrote: > On 10/12/2016 01:47 PM, Michal Hocko wrote: [...] > Acked-by: Vlastimil Babka Thanks! > > Small nitpick below. > > > @@ -1696,14 +1703,16 @@ enum compact_result try_to_compact_pages(gfp_t gfp_mask, unsigned int order, > > unsigned int alloc_flags, const struct alloc_context *ac, > > enum compact_priority prio) > > { > > - int may_enter_fs = gfp_mask & __GFP_FS; > > int may_perform_io = gfp_mask & __GFP_IO; > > struct zoneref *z; > > struct zone *zone; > > enum compact_result rc = COMPACT_SKIPPED; > > > > - /* Check if the GFP flags allow compaction */ > > - if (!may_enter_fs || !may_perform_io) > > + /* > > + * Check if the GFP flags allow compaction - GFP_NOIO is really > > + * tricky context because the migration might require IO and > > "and" ? a leftover from a longer comment. s@ and@.@ Thanks for the review! -- Michal Hocko SUSE Labs