From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Azhar Shaikh <azhar.shaikh@intel.com>
Cc: lee.jones@linaro.org, andriy.shevchenko@intel.com,
heikki.krogerus@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: Do not put device in reset state on suspend
Date: Thu, 13 Oct 2016 10:22:39 +0300 [thread overview]
Message-ID: <20161013072239.GE2774@lahna.fi.intel.com> (raw)
In-Reply-To: <20161012171220.6429-1-azhar.shaikh@intel.com>
On Wed, Oct 12, 2016 at 10:12:20AM -0700, Azhar Shaikh wrote:
> Commit 41a3da2b8e163 ("mfd: intel-lpss: Save register context on
> suspend") saved the register context while going to suspend and
> also put the device in reset state.
>
> Due to the resetting of device, system cannot enter S3/S0ix
> states when no_console_suspend flag is enabled. The system
> and serial console both hang. The resetting of device is not
> needed while going to suspend. Hence remove this code.
>
> Fixes: 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend")
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2016-10-13 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 17:12 Azhar Shaikh
2016-10-12 17:24 ` Andy Shevchenko
2016-10-13 7:22 ` Mika Westerberg [this message]
2016-10-26 12:30 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013072239.GE2774@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=azhar.shaikh@intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome