mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linaro-kernel@lists.linaro.org, linus.walleij@linaro.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev
Date: Thu, 13 Oct 2016 15:05:41 +0100	[thread overview]
Message-ID: <20161013140541.GA11758@arch-late.localdomain> (raw)
In-Reply-To: <9b48c2f62b23ef3565af2779fc2d46dcaf02d55a.1476239450.git.viresh.kumar@linaro.org>

Hi Viresh,
On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote:
>Some of the print messages are using the incorrect device pointer, fix
>them.
>
>Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>

Thanks,
   Rui
>---
> drivers/staging/greybus/gpio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
>index 5e06e4229e42..250caa00de5e 100644
>--- a/drivers/staging/greybus/gpio.c
>+++ b/drivers/staging/greybus/gpio.c
>@@ -702,15 +702,13 @@ static int gb_gpio_probe(struct gbphy_device *gbphy_dev,
> 	ret = gb_gpio_irqchip_add(gpio, irqc, 0,
> 				   handle_level_irq, IRQ_TYPE_NONE);
> 	if (ret) {
>-		dev_err(&connection->bundle->dev,
>-			"failed to add irq chip: %d\n", ret);
>+		dev_err(&gbphy_dev->dev, "failed to add irq chip: %d\n", ret);
> 		goto exit_line_free;
> 	}
>
> 	ret = gpiochip_add(gpio);
> 	if (ret) {
>-		dev_err(&connection->bundle->dev,
>-			"failed to add gpio chip: %d\n", ret);
>+		dev_err(&gbphy_dev->dev, "failed to add gpio chip: %d\n", ret);
> 		goto exit_gpio_irqchip_remove;
> 	}
>
>-- 
>2.7.1.410.g6faf27b
>

  parent reply	other threads:[~2016-10-13 14:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-12  2:32 Viresh Kumar
2016-10-12  2:32 ` [PATCH 2/2] Staging: greybus: uart: " Viresh Kumar
2016-10-15 11:20   ` Johan Hovold
2016-10-13 14:05 ` Rui Miguel Silva [this message]
2016-10-15 11:18 ` [PATCH 1/2] Staging: greybus: gpio: " Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161013140541.GA11758@arch-late.localdomain \
    --to=rmfrfs@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®