From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alexis Berlemont <alexis.berlemont@gmail.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com
Subject: Re: [PATCH] perf: dynamically change verbosity level in perf top
Date: Fri, 14 Oct 2016 12:49:59 -0300 [thread overview]
Message-ID: <20161014154959.GG12815@kernel.org> (raw)
In-Reply-To: <20161012214823.14324-1-alexis.berlemont@gmail.com>
Em Wed, Oct 12, 2016 at 11:48:22PM +0200, Alexis Berlemont escreveu:
> Hi,
>
> Here is a small patch which tries to fulfill a point in the perf todo
> list:
>
> * Make pressing 'V' multiple times to go on cycling thru various
> verbosity levels in 'perf top', so that info that is present in
> 'perf top -v' can be obtained without having to restart the tool
> (acme).
>
> After a small grep in the code, the max verbosity level seems 3; so,
> we cycle at 4; I did not dare define a MAX_VERBOSE_LEVEL constant.
Works like a charm, thanks for doing this, feel free to go over other
entries in that list :-)
I made changes only in the cset log message, adding the text you wrote
above and adding a:
Suggested-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Thanks!
- Arnaldo
> Alexis.
>
> Alexis Berlemont (1):
> perf: dynamically change verbosity level in perf top
>
> tools/perf/ui/browsers/hists.c | 5 ++++-
> tools/perf/util/map.c | 17 ++++++++++++-----
> 2 files changed, 16 insertions(+), 6 deletions(-)
>
> --
> 2.10.0
prev parent reply other threads:[~2016-10-14 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 21:48 Alexis Berlemont
2016-10-12 21:48 ` Alexis Berlemont
2016-10-24 19:03 ` [tip:perf/core] perf hists browser: Dynamically change verbosity level tip-bot for Alexis Berlemont
2016-10-14 15:49 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014154959.GG12815@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexis.berlemont@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome