From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480AbcJPHeH (ORCPT ); Sun, 16 Oct 2016 03:34:07 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36005 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbcJPHeG (ORCPT ); Sun, 16 Oct 2016 03:34:06 -0400 Date: Sun, 16 Oct 2016 09:33:41 +0200 From: Michal Hocko To: Janani Ravichandran Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] scripts: Include postprocessing script for memory allocation tracing Message-ID: <20161016073340.GA15839@dhcp22.suse.cz> References: <20160911222411.GA2854@janani-Inspiron-3521> <20160912121635.GL14524@dhcp22.suse.cz> <0ACE5927-A6E5-4B49-891D-F990527A9F50@gmail.com> <20160919094224.GH10785@dhcp22.suse.cz> <20160923080709.GB4478@dhcp22.suse.cz> <2D27EF16-B63B-4516-A156-5E2FB675A1BB@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2D27EF16-B63B-4516-A156-5E2FB675A1BB@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 15-10-16 19:31:22, Janani Ravichandran wrote: > > > On Oct 11, 2016, at 10:43 AM, Janani Ravichandran wrote: > > > > Alright. I’ll add a starting tracepoint, change the script accordingly and > > send a v2. Thanks! > > > I looked at it again and I think that the context information we need > can be obtained from the tracepoint trace_mm_page_alloc in > alloc_pages_nodemask(). trace_mm_page_alloc will tell you details about the allocation, like gfp mask, order but it doesn't tell you how long the allocation took at its current form. So either you have to note jiffies at the allocation start and then add the end-start in the trace point or we really need another trace point to note the start. The later has an advantage that we do not add unnecessary load for jiffies when the tracepoint is disabled. -- Michal Hocko SUSE Labs