From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756759AbcJPQqt (ORCPT ); Sun, 16 Oct 2016 12:46:49 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56043 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbcJPQqo (ORCPT ); Sun, 16 Oct 2016 12:46:44 -0400 Date: Sun, 16 Oct 2016 09:45:56 -0700 From: Christoph Hellwig To: kbuild test robot , jonas@southpole.se Cc: Dave Chinner , kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: fs/xfs/xfs_ondisk.h:96:2: error: call to '__compiletime_assert_96' declared with attribute error: XFS: sizeof(xfs_dir2_sf_entry_t) is wrong, expected 3 Message-ID: <20161016164556.GA30222@infradead.org> References: <201610161706.PmSovtpj%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201610161706.PmSovtpj%fengguang.wu@intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > head: 1001354ca34179f3db924eb66672442a173147dc That's Linux 4.9-rc1 > 30cbc591 Darrick J. Wong 2016-03-09 @86 XFS_CHECK_STRUCT_SIZE(xfs_dir2_data_unused_t, 6); But that's not how xfs_ondisk.h in 4.9-rc1 looks like > 30cbc591 Darrick J. Wong 2016-03-09 @96 XFS_CHECK_STRUCT_SIZE(xfs_dir2_sf_entry_t, 3); And that's line 119. Something is odd about this report. But both xfs_dir2_data_unused_t and xfs_dir2_sf_entry_t have one thing in common: they are strutures that aren't padded to a natural alignment at the end. It seems like the openrisc gcc does implicit padding for them, which sounds like a nightmware waiting to happen for any sort of disk or network structure, so I'm really not sure if we should work around it in xfs.