From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934979AbcJQOen (ORCPT ); Mon, 17 Oct 2016 10:34:43 -0400 Received: from mga01.intel.com ([192.55.52.88]:22812 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934054AbcJQOeg (ORCPT ); Mon, 17 Oct 2016 10:34:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,357,1473145200"; d="scan'208";a="773598473" Date: Mon, 17 Oct 2016 22:09:10 +0800 From: Fengguang Wu To: Christoph Hellwig Cc: jonas@southpole.se, Dave Chinner , kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: [kbuild-all] fs/xfs/xfs_ondisk.h:96:2: error: call to '__compiletime_assert_96' declared with attribute error: XFS: sizeof(xfs_dir2_sf_entry_t) is wrong, expected 3 Message-ID: <20161017140910.uev6b4pk74xfqfpp@wfg-t540p.sh.intel.com> References: <201610161706.PmSovtpj%fengguang.wu@intel.com> <20161016164556.GA30222@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20161016164556.GA30222@infradead.org> User-Agent: Mutt/1.6.2-neo (2016-08-08) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, On Sun, Oct 16, 2016 at 09:45:56AM -0700, Christoph Hellwig wrote: > > >> head: 1001354ca34179f3db924eb66672442a173147dc > >That's Linux 4.9-rc1 > >> 30cbc591 Darrick J. Wong 2016-03-09 @86 XFS_CHECK_STRUCT_SIZE(xfs_dir2_data_unused_t, 6); > >But that's not how xfs_ondisk.h in 4.9-rc1 looks like Yeah it's a bit confusing for old errors -- the git blame is on the old first bad commit, which is ab9d1e4f7b0217948a3b35a64178602ab30ff45d Merge branch 'xfs-misc-fixes-4.6-3' into for-next >> 30cbc591 Darrick J. Wong 2016-03-09 @96 XFS_CHECK_STRUCT_SIZE(xfs_dir2_sf_entry_t, 3); > >And that's line 119. > >Something is odd about this report. > >But both xfs_dir2_data_unused_t and xfs_dir2_sf_entry_t have one thing in >common: they are strutures that aren't padded to a natural alignment at >the end. It seems like the openrisc gcc does implicit padding for them, >which sounds like a nightmware waiting to happen for any sort of disk >or network structure, so I'm really not sure if we should work around >it in xfs. FYI the error for 'xfs_dir2_sf_entry_t' only shows up in openrisc; and the 'xfs_attr_shortform_t' error only shows up in cris builds. There is no errors for 'xfs_dir2_data_unused_t' in recent kernels. Thanks, Fengguang