From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757789AbcJQORz (ORCPT ); Mon, 17 Oct 2016 10:17:55 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:45215 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757685AbcJQORe (ORCPT ); Mon, 17 Oct 2016 10:17:34 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: hong.gyu.kim@lge.com X-Original-SENDERIP: 165.244.249.25 X-Original-MAILFROM: hong.gyu.kim@lge.com X-Original-SENDERIP: 10.177.222.39 X-Original-MAILFROM: hong.gyu.kim@lge.com From: Honggyu Kim To: CC: , Honggyu Kim Subject: [PATCH 2/3] tools lib traceevent: Check the return value of asprintf Date: Mon, 17 Oct 2016 23:17:11 +0900 Message-ID: <20161017141712.11932-2-hong.gyu.kim@lge.com> X-Mailer: git-send-email 2.10.0.rc2.dirty In-Reply-To: <20161017141712.11932-1-hong.gyu.kim@lge.com> References: <20161017141712.11932-1-hong.gyu.kim@lge.com> X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/10/17 23:17:31, Serialize by Router on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2016/10/17 23:17:31, Serialize complete at 2016/10/17 23:17:31 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since asprintf generates a compiler warning when its return value is not not properly handled, this patch checks that asprintf call is successful or not. Signed-off-by: Honggyu Kim --- tools/lib/traceevent/parse-filter.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index 7c214ce..f0fcdcd 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c @@ -2122,7 +2122,8 @@ static char *op_to_str(struct event_filter *filter, struct filter_arg *arg) default: break; } - asprintf(&str, val ? "TRUE" : "FALSE"); + if (asprintf(&str, val ? "TRUE" : "FALSE") < 0) + return NULL; break; } } @@ -2140,7 +2141,8 @@ static char *op_to_str(struct event_filter *filter, struct filter_arg *arg) break; } - asprintf(&str, "(%s) %s (%s)", left, op, right); + if (asprintf(&str, "(%s) %s (%s)", left, op, right) < 0) + return NULL; break; case FILTER_OP_NOT: @@ -2156,10 +2158,12 @@ static char *op_to_str(struct event_filter *filter, struct filter_arg *arg) right_val = 0; if (right_val >= 0) { /* just return the opposite */ - asprintf(&str, right_val ? "FALSE" : "TRUE"); + if (asprintf(&str, right_val ? "FALSE" : "TRUE") < 0) + return NULL; break; } - asprintf(&str, "%s(%s)", op, right); + if (asprintf(&str, "%s(%s)", op, right) < 0) + return NULL; break; default: @@ -2175,7 +2179,8 @@ static char *val_to_str(struct event_filter *filter, struct filter_arg *arg) { char *str = NULL; - asprintf(&str, "%lld", arg->value.val); + if (asprintf(&str, "%lld", arg->value.val) < 0) + return NULL; return str; } @@ -2233,7 +2238,8 @@ static char *exp_to_str(struct event_filter *filter, struct filter_arg *arg) break; } - asprintf(&str, "%s %s %s", lstr, op, rstr); + if (asprintf(&str, "%s %s %s", lstr, op, rstr) < 0) + return NULL; out: free(lstr); free(rstr); @@ -2277,7 +2283,8 @@ static char *num_to_str(struct event_filter *filter, struct filter_arg *arg) if (!op) op = "<="; - asprintf(&str, "%s %s %s", lstr, op, rstr); + if (asprintf(&str, "%s %s %s", lstr, op, rstr) < 0) + return NULL; break; default: @@ -2312,8 +2319,9 @@ static char *str_to_str(struct event_filter *filter, struct filter_arg *arg) if (!op) op = "!~"; - asprintf(&str, "%s %s \"%s\"", - arg->str.field->name, op, arg->str.val); + if (asprintf(&str, "%s %s \"%s\"", + arg->str.field->name, op, arg->str.val) < 0) + return NULL; break; default: @@ -2329,7 +2337,8 @@ static char *arg_to_str(struct event_filter *filter, struct filter_arg *arg) switch (arg->type) { case FILTER_ARG_BOOLEAN: - asprintf(&str, arg->boolean.value ? "TRUE" : "FALSE"); + if (asprintf(&str, arg->boolean.value ? "TRUE" : "FALSE") < 0) + return NULL; return str; case FILTER_ARG_OP: -- 2.10.0.rc2.dirty