From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936229AbcJQRAp (ORCPT ); Mon, 17 Oct 2016 13:00:45 -0400 Received: from mx4.wp.pl ([212.77.101.12]:38432 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933464AbcJQRAe (ORCPT ); Mon, 17 Oct 2016 13:00:34 -0400 Date: Mon, 17 Oct 2016 18:00:27 +0100 From: Jakub Kicinski To: David Miller Cc: jarod@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove usage Message-ID: <20161017180027.4936fa15@jkicinski-Precision-T1700> In-Reply-To: <20161017.124954.360760874377344385.davem@davemloft.net> References: <20161008020434.9691-1-jarod@redhat.com> <20161008020434.9691-3-jarod@redhat.com> <20161017172006.4d549daa@jkicinski-Precision-T1700> <20161017.124954.360760874377344385.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: a9b44a2b8a7c54c7d82b701c590f1adf X-WP-AV: skaner antywirusowy poczty Nowej Poczty X-WP-SPAM: NO 0000000 [UaMU] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote: > From: Jakub Kicinski > Date: Mon, 17 Oct 2016 17:20:06 +0100 > > > Please correct me if I'm wrong but it seems like we are now limiting > > _all_ ethernet drivers to ETH_DATA_LEN in net-next. > > No, because the driver can increase the netdev->max_mtu value as needed. But since almost no driver is doing that, yet, right now in net-next jumbo frames are not possible, no? I thought the idea was the leave the value at 0 so drivers can opt-in as needed but since setup_ether() is initializing to 1500 now all ethernet driver get a default of limiting to 1500. IOW this patch made checks which were done only in eth_change_mtu() mandatory for all drivers.