From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938680AbcJRP5V (ORCPT ); Tue, 18 Oct 2016 11:57:21 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:43244 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937225AbcJRP5L (ORCPT ); Tue, 18 Oct 2016 11:57:11 -0400 Date: Tue, 18 Oct 2016 11:57:07 -0400 (EDT) Message-Id: <20161018.115707.1632276930668736889.davem@davemloft.net> To: zach.brown@ni.com Cc: f.fainelli@gmail.com, mlindner@marvell.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, rpurdie@rpsys.net, j.anaszewski@samsung.com, linux-leds@vger.kernel.org, andrew@lunn.ch Subject: Re: [PATCH v5 0/4] Add support for led triggers on phy link state change From: David Miller In-Reply-To: <1476719395-28273-1-git-send-email-zach.brown@ni.com> References: <1476719395-28273-1-git-send-email-zach.brown@ni.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 18 Oct 2016 08:57:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zach Brown Date: Mon, 17 Oct 2016 10:49:51 -0500 > Fix skge driver that declared enum contants that conflicted with enum > constants in linux/leds.h > > Create function that encapsulates actions taken during the adjust phy link step > of phy state changes. > > Create function that provides list of speeds currently supported by the phy. > > Add support for led triggers on phy link state changes by adding > a config option. When set the config option will create a set of led triggers > for each phy device. Users can use the led triggers to represent link state > changes on the phy. Ok this looks good enough for now, we can expand and improve upon it later if necessary. Series applied, thanks Zach.