From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034441AbcJRSao (ORCPT ); Tue, 18 Oct 2016 14:30:44 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:45300 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933100AbcJRSa0 (ORCPT ); Tue, 18 Oct 2016 14:30:26 -0400 Date: Tue, 18 Oct 2016 14:30:25 -0400 (EDT) Message-Id: <20161018.143025.284251297276702898.davem@davemloft.net> To: stefan.wahren@i2se.com Cc: gregkh@linuxfoundation.org, jslaby@suse.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver From: David Miller In-Reply-To: <1476790054-27174-9-git-send-email-stefan.wahren@i2se.com> References: <1476790054-27174-1-git-send-email-stefan.wahren@i2se.com> <1476790054-27174-9-git-send-email-stefan.wahren@i2se.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 18 Oct 2016 11:30:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Wahren Date: Tue, 18 Oct 2016 13:27:34 +0200 > +void > +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp, > + int count) > +{ > + struct qcauart *qca = tty->disc_data; > + struct net_device_stats *n_stats = &qca->net_dev->stats; > + int dropped = 0; Please order local variable declarations from longest to shortest line. > +netdev_tx_t > +qcauart_netdev_xmit(struct sk_buff *skb, struct net_device *dev) > +{ > + struct qcauart *qca = netdev_priv(dev); > + struct net_device_stats *n_stats = &dev->stats; > + u8 *pos; > + u8 pad_len = 0; > + int written; Likewise.