From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943309AbcJSOvD (ORCPT ); Wed, 19 Oct 2016 10:51:03 -0400 Received: from up.free-electrons.com ([163.172.77.33]:60611 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S941907AbcJSOtu (ORCPT ); Wed, 19 Oct 2016 10:49:50 -0400 Date: Wed, 19 Oct 2016 09:41:18 +0200 From: Alexandre Belloni To: Gabriele Mazzotta Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] rtc-cmos: Reject unsupported alarm values Message-ID: <20161019074118.zyqgfa672wkvl7dm@piout.net> References: <20160902195516.7068-1-gabriele.mzt@gmail.com> <20161003225028.3529-1-gabriele.mzt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161003225028.3529-1-gabriele.mzt@gmail.com> User-Agent: NeoMutt/20160916 (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 04/10/2016 at 00:50:28 +0200, Gabriele Mazzotta wrote : > Some platforms allows to specify the month and day of the month in > which an alarm should go off, some others the day of the month and > some others just the time. > > Currently any given value is accepted by the driver and only the > supported fields are used to program the hardware. As consequence, > alarms are potentially programmed to go off in the wrong moment. > > Fix this by rejecting any unsupported value. > > Signed-off-by: Gabriele Mazzotta > --- > drivers/rtc/rtc-cmos.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 72 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com