From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S946015AbcJSQAg (ORCPT ); Wed, 19 Oct 2016 12:00:36 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.140]:25474 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S945937AbcJSQA2 (ORCPT ); Wed, 19 Oct 2016 12:00:28 -0400 X-Greylist: delayed 6532 seconds by postgrey-1.27 at vger.kernel.org; Wed, 19 Oct 2016 12:00:28 EDT X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRWlGSWpSXmKPExsUS8J9tou6LdPY IgytdshbfDyZYPO6awWpxedccNgdmj8c9Z9g8Np+u9vi8SS6AOYo1My8pvyKBNWPx5VfMBRPZ Kg5OP8PewDiHtYuRk0NIoIFRYldPQRcjB4eEgJ/Ehc/sXYxcQOH5jBIt7euYQWrYBLQkzs+6w wRiiwhISFzrWAvWyywQL/Fyzm8WEFtYwEXi2Y6pYPUsAqoSO173g9XwClhKdEy7ygZiSwjIS1 z7/o8NIi4ocXLmExaIGxQlljf+Y4aokZPo/N7BDnFPnMSXO6YQprXExM2JEFslJA6+eME8gVF gFpJBs5CkFjAyrWLUKE4tKkst0jU01EsqykzPKMlNzMzRNTQw1ctNLS5OTE/NSUwq1kvOz93E CAxRBiDYwbiy3fkQoyQHk5Ior08Ue4QQX1J+SmVGYnFGfFFpTmrxIUYZDg4lCd6ENKCcYFFqe mpFWmYOMFpg0hIcPEoivFdB0rzFBYm5xZnpEKlTjLocC37cXsskxJKXn5cqJc7bCFIkAFKUUZ oHNwIWuZcYZaWEeRmBjhLiKUgtys0sQZV/xSjOwagkzLsTZApPZl4J3KZXQEcwAR1xLo8F5Ii SRISUVAOj9vO5s33Kvfm1vNTtczfujbzU6Pr/oJjGnmPCH9pczjB+UZjwsf3Vba/bzqvaLj7a qsN1y3+1r9t875Q3R66//nskMeJekMKtBTPYzc9qrvbq//jo8i3d5Eczb1eerNx5MKZMVX+Hx flV/Hdq3KdUFJfdEdFrqdw7pcvcm93wQM9fhtnr4+zYlViKMxINtZiLihMBdFgRydcCAAA= X-Env-Sender: michael.moese@men.de X-Msg-Ref: server-2.tower-180.messagelabs.com!1476880359!61073480!1 X-Originating-IP: [80.255.6.145] X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked X-PGP-Universal: processed; by keys.men.de on Wed, 19 Oct 2016 14:32:40 +0200 From: Michael Moese To: CC: , , Michael Moese Subject: [PATCH] mcb: fix compiler warning logical-op in mcb-parse.c Date: Wed, 19 Oct 2016 14:37:24 +0200 Message-ID: <20161019123724.27009-1-michael.moese@men.de> X-Mailer: git-send-email 2.10.0 MIME-Version: 1.0 X-Originating-IP: [192.1.2.30] X-ClientProxiedBy: MEN-EX01.intra.men.de (192.168.1.1) To MEN-EX01.intra.men.de (192.168.1.1) X-EXCLAIMER-MD-CONFIG: e4841e51-7998-49c0-ba41-8b8a0e2d8962 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The expression was clearly wrong, the logical AND of expressions must be changed to a logical OR. Reported-by: David Binderman Signed-off-by: Michael Moese --- drivers/mcb/mcb-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c index 4ca2739..ee7fb6e 100644 --- a/drivers/mcb/mcb-parse.c +++ b/drivers/mcb/mcb-parse.c @@ -149,7 +149,7 @@ static int chameleon_get_bar(char __iomem **base, phys_addr_t mapbase, reg = readl(*base); bar_count = BAR_CNT(reg); - if (bar_count <= 0 && bar_count > CHAMELEON_BAR_MAX) + if (bar_count <= 0 || bar_count > CHAMELEON_BAR_MAX) return -ENODEV; c = kcalloc(bar_count, sizeof(struct chameleon_bar), -- 2.10.0