From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944468AbcJSPIL (ORCPT ); Wed, 19 Oct 2016 11:08:11 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36752 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942567AbcJSPII (ORCPT ); Wed, 19 Oct 2016 11:08:08 -0400 Date: Wed, 19 Oct 2016 17:08:03 +0200 From: Henrik Austad To: Jesse Brandeburg Cc: linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [Intel-wired-lan] [PATCH] igb: add missing fields to TXDCTL-register Message-ID: <20161019150803.GA20691@icarus.home.austad.us> References: <1476880679-16221-1-git-send-email-henrik@austad.us> <20161019072510.00002b0e@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline In-Reply-To: <20161019072510.00002b0e@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 19, 2016 at 07:25:10AM -0700, Jesse Brandeburg wrote: > On Wed, 19 Oct 2016 14:37:59 +0200 > Henrik Austad wrote: >=20 > > The current list of E1000_TXDCTL-registers is incomplete. This adds > > the missing parts for the Transmit Descriptor Control (TXDCTL) > > register. > >=20 > > The rest of these values (threshold for descriptor read/write) for > > TXDCTL seems to be defined in igb/igb.h, not sure why this is split > > though. >=20 > Hi Henrik, thanks for helping with our code. >=20 > While totally correct, having defines added to the kernel that are not > being used anywhere in the code isn't really very useful. Often the > upstream maintainers/reviewers will reject a patch like this that just > adds to a .h file, because there are no actual users of the defines. Yes, I agree, best to avoid bloat whenever possible. > If the transmit or ethtool code were to use these (via the same patch) > or something like that, then the patch would be more likely to be > accepted. Ah, good to know. I am in the process of spinning out a new set of=20 TSN-patches (previous version: see [1]) and setting the priority-bit for=20 the Tx-queues is required. This means that I'm hacking more at igb_main.c. So this was more about laying the groundwork for the series. I'll leave this patch in the tsn-series then, and resend once I'm ready and= =20 hope you can provide some feedback on the rest of the series then :) > Jesse >=20 > PS In the future no need to copy linux-kernel for patches going to our > submaintainer list. Ok, I'll remember that, thanks! 1) https://lkml.org/lkml/2016/6/11/187 --=20 Henrik Austad --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlgHjFMACgkQ6k5VT6v45lnY6ACghUjAm/3yM8Tpz0srwU8vKoEr sfgAoOz2fq2Tov99peXLkWEasDdad8gI =P6bL -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh--