From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753882AbcJUD3Y (ORCPT ); Thu, 20 Oct 2016 23:29:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39994 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752810AbcJUD3U (ORCPT ); Thu, 20 Oct 2016 23:29:20 -0400 Date: Thu, 20 Oct 2016 20:29:18 -0700 From: Andrew Morton To: Sudip Mukherjee Cc: linux-kernel@vger.kernel.org, fengguang.wu@intel.com Subject: Re: [PATCH] m32r: add simple dma Message-Id: <20161020202918.b7cb3fe24058addddabb7534@linux-foundation.org> In-Reply-To: <1475949198-31623-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1475949198-31623-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 8 Oct 2016 23:23:18 +0530 Sudip Mukherjee wrote: > Some builds of m32r were failing as it tried to build few drivers which > needed dma but m32r is not having dma support. Objections were raised > when it was tried to make those drivers depend on HAS_DMA. Huh. What were these objections? That sounds like the appropriate fix. And I suggest that a summary of those objections be captured in this patch's changelog. > So the next > best thing is to add dma support to m32r. > dma_noop is a very simple dma with 1:1 memory mapping. > > Signed-off-by: Sudip Mukherjee > --- > > Hi Andrew, > Just to let you know that this was not tested on any board. I think I > have told you earlier that inspite of all my efforts I could not find > any source of information to procure a board of m32r. It is a worry. We're saying "m32r linux now supports these drivers", only we don't know if that is true. > Hi Fengguang, > If Andrew accepts this patch then it will open pandora's box as lots of > other drivers which were never build for m32r will be built now and you > are going to gets lots and lots of new build warnings. But nothing > breaks.