From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752931AbcJUDlZ (ORCPT ); Thu, 20 Oct 2016 23:41:25 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40179 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbcJUDlY (ORCPT ); Thu, 20 Oct 2016 23:41:24 -0400 Date: Thu, 20 Oct 2016 20:41:22 -0700 From: Andrew Morton To: chengang@emindsoft.com.cn Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, Chen Gang Subject: Re: [PATCH] uapi: linux: acct: Remove redundant type comp2_t from kernel Message-Id: <20161020204122.2afc9264b4671add55112fe7@linux-foundation.org> In-Reply-To: <1475674810-1560-1-git-send-email-chengang@emindsoft.com.cn> References: <1475674810-1560-1-git-send-email-chengang@emindsoft.com.cn> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Oct 2016 21:40:10 +0800 chengang@emindsoft.com.cn wrote: > In api itself, kernel does not use it -- it is divided into ac_etime_hi > and ac_etime_lo. So kernel side only need generate the correct > ac_etime_hi and ac_etime_lo, but need not know about comp2_t. > > At present, kernel use normal u64 type for it, when kernel provdes it to > outside, kernel can translate it into ac_etime_hi and ac_etime_lo, > directly, but need not notice about comp2_t, in fact. hm. Why is this an improvement?