From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755629AbcJUONx (ORCPT ); Fri, 21 Oct 2016 10:13:53 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55344 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754883AbcJUONv (ORCPT ); Fri, 21 Oct 2016 10:13:51 -0400 Date: Fri, 21 Oct 2016 10:13:43 -0400 (EDT) Message-Id: <20161021.101343.1389577512803674816.davem@davemloft.net> To: ebiederm@xmission.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au Subject: Re: [PATCH] kexec: Export kexec_in_progress to modules From: David Miller In-Reply-To: <871szagtls.fsf@xmission.com> References: <1477012516-20470-1-git-send-email-f.fainelli@gmail.com> <20161020.215410.650162338407203719.davem@davemloft.net> <871szagtls.fsf@xmission.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 21 Oct 2016 07:13:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ebiederm@xmission.com (Eric W. Biederman) Date: Fri, 21 Oct 2016 00:26:55 -0500 > So as far as I can tell you are advocating for a change to support a > driver doing something that is completely pointless. So no let's not > export this symbol. Please fix the driver to do something less > pointless instead. FLorian explained his reasoning for doing what he is doing in this specific driver and it made sense to me.