From: Tony Lindgren <tony@atomide.com>
To: Jeroen Hofstee <jhofstee@victronenergy.com>
Cc: netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: cpsw: fix obtaining mac address for am3517
Date: Fri, 21 Oct 2016 02:51:38 -0700 [thread overview]
Message-ID: <20161021095137.ypyr7wnwzhum65ua@atomide.com> (raw)
In-Reply-To: <6dbeca0a-65ad-3a1c-2fe5-60023d83dabd@victronenergy.com>
* Jeroen Hofstee <jhofstee@victronenergy.com> [161021 02:31]:
> Aaah, lets wait a sec. I just saw there is another user of this function,
> so above is simply not true....
>
> if (of_machine_is_compatible("ti,dra7"))
> return davinci_emac_3517_get_macid(dev, 0x514, slave, mac_addr);
Oh OK, then this will produce duplicate macs.
> So let me check if I don't break that one..... or better, let me send a v2,
> which
> changes the caller to pass slave as 0 here?
>
> if (of_device_is_compatible(dev->of_node, "ti,am3517-emac"))
> return davinci_emac_3517_get_macid(dev, 0x110, slave, mac_addr);
>
Yeah that sounds good to me.
Regards,
Tony
prev parent reply other threads:[~2016-10-21 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1476993351-23065-1-git-send-email-jhofstee@victronenergy.com>
2016-10-21 6:38 ` Tony Lindgren
2016-10-21 7:36 ` Jeroen Hofstee
2016-10-21 7:53 ` Tony Lindgren
2016-10-21 9:30 ` Jeroen Hofstee
2016-10-21 9:51 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021095137.ypyr7wnwzhum65ua@atomide.com \
--to=tony@atomide.com \
--cc=grygorii.strashko@ti.com \
--cc=jhofstee@victronenergy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®