From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH] block: Change extern inline to static inline
Date: Fri, 21 Oct 2016 17:29:00 +0300 [thread overview]
Message-ID: <20161021142900.GY24289@lahna.fi.intel.com> (raw)
In-Reply-To: <20161021141926.7207-1-tklauser@distanz.ch>
On Fri, Oct 21, 2016 at 04:19:26PM +0200, Tobias Klauser wrote:
> With compilers which follow the C99 standard (like modern versions of
> gcc and clang), "extern inline" does the opposite thing from older
> versions of gcc (emits code for an externally linkable version of the
> inline function).
>
> "static inline" does the intended behavior in all cases instead.
>
> Description taken from commit 6d91857d4826 ("staging, rtl8192e,
> LLVMLinux: Change extern inline to static inline").
>
> This also fixes the following GCC warning when building with !PM:
> ./include/linux/blkdev.h:1143:20: warning: no previous prototype for 'blk_set_runtime_active' [-Wmissing-prototypes]
>
> Fixes: d07ab6d11477 ("block: Add blk_set_runtime_active()")
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Hehe, indeed that "extern" was probably copy pasted from the non-inline
declaration.
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
prev parent reply other threads:[~2016-10-21 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 14:19 Tobias Klauser
2016-10-21 14:29 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021142900.GY24289@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=axboe@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®