From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755794AbcJUP0s (ORCPT ); Fri, 21 Oct 2016 11:26:48 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:58104 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753735AbcJUP0r (ORCPT ); Fri, 21 Oct 2016 11:26:47 -0400 From: Arnd Bergmann To: Daniel Vetter , Jani Nikula Cc: Zhi Wang , Zhenyu Wang , Arnd Bergmann , David Airlie , Chris Wilson , Joonas Lahtinen , Tvrtko Ursulin , Andreas Ziegler , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] drm/i915/gvt: add ACPI and 64BIT dependencies Date: Fri, 21 Oct 2016 17:25:49 +0200 Message-Id: <20161021152620.3324407-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:haPabR3uF57r3g9O8MLf48j+W1OdTJJinxdPfG+AFjfoaX1iMG9 HWXBx78X+Wpy17F44qFJmEQL1CCF7ru/PcFkcqBjIJKi9LS62iPKN6PbPN4YltPQ/jC6uo7 s1xHnuQEUH6Bw1npdmsxR8bKoGKTW5R5bn2looTTbapAgR2O+nDW09GMxay1edtq9bGEsLa /063JOcrTO7LP6Gl5ZAEg== X-UI-Out-Filterresults: notjunk:1;V01:K0:p/ypMQAdhbM=:Ci8QTgZFs3WVY6A3ZewmIQ XMMLLVs0rxlWPwqYu+l5yxQiCO5NJP9iJfGPc1mfyWYRLLxQu6akrFr4tH96FDnD+Q/Gc8VHv djHmxxiN0ylyfriGMoMfBp6F+U6KsdquUqJ3Lyc8zvgTzr7YCHKiBreIq60lCjg3HsRe1UlGr 55U7kALnUqkhr1MqVLJy0DEO1T+QMrb+hoeA9+HYSRrbKilDJxuZ/m5Qj8J1+Jcsaj47SJB9B /VMFtWHnboXtKfVzOFMR+8GlqkvI395vjLeyBqGu/PvgSOjLrUyboX1n3idbQO239IHeXWyjB QYK2mPNdoUGOpgD+57MgqOpNGxNGRPejssW7asX/HFzvO0rbUBxsAG0neQrwmdL8yd7R9Rj6V L6HiO9f+VWcTYEc3LCxKlCyqVkiuBkJAG7ssNWTaIrzTUnC7EprSO5eLGX9WqKCXjtPxta3Nw BbeCjkJA5P1TqEo3GFU1LDF6J23Vg6ynyxcsVwhfxVZys4Bvim03DgjeAWzt1GsPymCz/pFYb k9go0YCl8HtupPGGQ8V2p8rz4T3149BnMO6SD8k37XYcQTKZ2KLnJj8g6r24dQh3uSNRHN5lz uC8+bi+eRxlnIcSWIkSHJx2eLfdY92S/nXLKZRAWopfOCUkVFVnOTgwjl4cgZNDXyV22uV0G+ wAwtmo31NQeFmEZYJ2bOF1fXbXqcnC0MsI2nvQK7nkXIaQv+es27G6BngTr5gCsjmZNtoqPH/ BsoHLEJYem0TNmpe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added gvt code produces lots of serious warnings and errors when either built on 32-bit x86, or built with ACPI disabled, e.g. drivers/gpu/drm/i915/gvt/gtt.c: In function ‘read_pte64’: drivers/gpu/drm/i915/gvt/gtt.c:277:2: error: left shift count >= width of type [-Werror] drivers/gpu/drm/i915/gvt/gtt.c: In function ‘gen8_gtt_get_pfn’: drivers/gpu/drm/i915/gvt/gtt.c:360:3: error: left shift count >= width of type [-Werror] drivers/gpu/drm/i915/gvt/opregion.c: In function ‘intel_gvt_init_opregion’: drivers/gpu/drm/i915/gvt/opregion.c:183:2: error: implicit declaration of function ‘acpi_os_ioremap’ [-Werror=implicit-function-declaration] This avoids the problems by simply disallowing those configurations in Kconfig. I'm sure it's possible to make the code more portable and support building GVT without those options, but it might not be useful to do so. Fixes: 4d60c5fd3f87 ("drm/i915/gvt: vGPU PCI configuration space virtualization") Signed-off-by: Arnd Bergmann --- If the code is meant to work on 32-bit and non-ACPI kernels, please treat this as a bug report and disregard the patch. --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index 6d4194288d11..1b9308284dde 100644 --- a/drivers/gpu/drm/i915/Kconfig +++ b/drivers/gpu/drm/i915/Kconfig @@ -84,6 +84,7 @@ config DRM_I915_USERPTR config DRM_I915_GVT bool "Enable Intel GVT-g graphics virtualization host support" depends on DRM_I915 + depends on 64BIT && ACPI default n help Choose this option if you want to enable Intel GVT-g graphics -- 2.9.0