From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934215AbcJUUdv (ORCPT ); Fri, 21 Oct 2016 16:33:51 -0400 Received: from mga01.intel.com ([192.55.52.88]:30150 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933682AbcJUUdu (ORCPT ); Fri, 21 Oct 2016 16:33:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,526,1473145200"; d="scan'208";a="892601153" Date: Fri, 21 Oct 2016 23:33:44 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Peter Huewe , Ed Swierk , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH 1/2] tpm: Clean up reading of timeout and duration capabilities Message-ID: <20161021203344.v76buscn5y377wjx@intel.com> References: <1474316530-17315-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1474316530-17315-2-git-send-email-jarkko.sakkinen@linux.intel.com> <20160919232406.GE22760@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160919232406.GE22760@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2016 at 05:24:06PM -0600, Jason Gunthorpe wrote: > On Mon, Sep 19, 2016 at 11:22:08PM +0300, Jarkko Sakkinen wrote: > > From: Ed Swierk > > > > Call tpm_getcap() from tpm_get_timeouts() to eliminate redundant > > code. Return all errors to the caller rather than swallowing them > > (e.g. when tpm_transmit_cmd() returns nonzero). > > I didn't look at these closely, but I agree with the idea. Tested-by: Jarkko Sakkinen /Jarkko