From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755886AbcJVTI6 (ORCPT ); Sat, 22 Oct 2016 15:08:58 -0400 Received: from smtprelay0116.hostedemail.com ([216.40.44.116]:34099 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751584AbcJVTI5 (ORCPT ); Sat, 22 Oct 2016 15:08:57 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2551:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:5007:6261:7514:7875:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12050:12114:12438:12555:12740:12760:13069:13311:13357:13439:14181:14659:14721:21080:21451:30029:30036:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: drink36_30ba1243f0c08 X-Filterd-Recvd-Size: 1953 Date: Sat, 22 Oct 2016 15:08:52 -0400 From: Steven Rostedt To: Nicholas Piggin Cc: LKML , Al Viro , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Gabriel C Subject: Re: [RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm Message-ID: <20161022150852.0e54e763@gandalf.local.home> In-Reply-To: <20161022104441.6a8f442f@roar.ozlabs.ibm.com> References: <20161021121759.74a635db@gandalf.local.home> <20161022104441.6a8f442f@roar.ozlabs.ibm.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 22 Oct 2016 10:44:41 +1100 Nicholas Piggin wrote: > > #ifdef CONFIG_FUNCTION_GRAPH_TRACER > > diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h > > index 43199a049da5..cb86e746865e 100644 > > --- a/include/asm-generic/export.h > > +++ b/include/asm-generic/export.h > > @@ -90,5 +90,10 @@ > > __EXPORT_SYMBOL(name, KSYM(name),) > > #define EXPORT_DATA_SYMBOL_GPL(name) \ > > __EXPORT_SYMBOL(name, KSYM(name),_gpl) > > +/* > > + * If "name" is a macro of a function and not a function itself, > > + * it needs a second pass. > > + */ > > +#define EXPORT_MACRO_SYMBOL(x) EXPORT_SYMBOL(x) > > Seems okay, but what about just calling it EXPORT_SYMBOL? Actually, this doesn't work. There's some magic going on it Makefile.build in the scripts directory that causes this to fail. I have another patch I'll be sending on Monday that fixes this. -- Steve