From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity
Date: Mon, 24 Oct 2016 11:02:43 +0900 [thread overview]
Message-ID: <20161024020246.14928-1-namhyung@kernel.org> (raw)
Applying cpu color always doesn't help readability IMHO. Instead it
might be better to applying the color when there's an activity on those
CPUs.
Cc: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index f5503ca22e1c..78006e991d91 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1479,7 +1479,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
cpu_color = COLOR_CPUS;
if (cpu != this_cpu)
- color_fprintf(stdout, cpu_color, " ");
+ color_fprintf(stdout, color, " ");
else
color_fprintf(stdout, cpu_color, "*");
--
2.10.0
next reply other threads:[~2016-10-24 2:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 2:02 Namhyung Kim [this message]
2016-10-24 2:02 ` [PATCH 2/3] perf sched map: Always show task comm with -v Namhyung Kim
2016-10-24 16:46 ` Jiri Olsa
2016-10-28 17:46 ` [tip:perf/core] " tip-bot for Namhyung Kim
2016-10-24 2:02 ` [PATCH 3/3] perf tools: Introduce timestamp_in_usec() Namhyung Kim
2016-10-24 16:46 ` Jiri Olsa
2016-10-24 20:56 ` Joonwoo Park
2016-10-28 17:46 ` [tip:perf/core] perf tools: Introduce timestamp__scnprintf_usec() tip-bot for Namhyung Kim
2016-10-24 16:46 ` [PATCH 1/3] perf sched map: Apply cpu color when there's an activity Jiri Olsa
2016-10-25 18:07 ` Arnaldo Carvalho de Melo
2016-10-25 21:24 ` Namhyung Kim
2016-10-28 17:45 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024020246.14928-1-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome