From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756964AbcJXB0B (ORCPT <rfc822;w@1wt.eu>);
        Sun, 23 Oct 2016 21:26:01 -0400
Received: from mail-pf0-f195.google.com ([209.85.192.195]:33632 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756890AbcJXBZ7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 23 Oct 2016 21:25:59 -0400
Date: Mon, 24 Oct 2016 12:25:45 +1100
From: Nicholas Piggin <npiggin@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Al Viro <viro@ZenIV.linux.org.uk>,
        Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>, Gabriel C <nix.or.die@gmail.com>
Subject: Re: [RFC][PATCH] Add EXPORT_MACRO_SYMBOL() for asm
Message-ID: <20161024122545.55539e53@roar.ozlabs.ibm.com>
In-Reply-To: <20161022150852.0e54e763@gandalf.local.home>
References: <20161021121759.74a635db@gandalf.local.home>
        <20161022104441.6a8f442f@roar.ozlabs.ibm.com>
        <20161022150852.0e54e763@gandalf.local.home>
Organization: IBM
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 22 Oct 2016 15:08:52 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sat, 22 Oct 2016 10:44:41 +1100
> Nicholas Piggin <npiggin@gmail.com> wrote:
> 
> > >  #ifdef CONFIG_FUNCTION_GRAPH_TRACER
> > > diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h
> > > index 43199a049da5..cb86e746865e 100644
> > > --- a/include/asm-generic/export.h
> > > +++ b/include/asm-generic/export.h
> > > @@ -90,5 +90,10 @@
> > >  	__EXPORT_SYMBOL(name, KSYM(name),)
> > >  #define EXPORT_DATA_SYMBOL_GPL(name)				\
> > >  	__EXPORT_SYMBOL(name, KSYM(name),_gpl)
> > > +/*
> > > + * If "name" is a macro of a function and not a function itself,
> > > + * it needs a second pass.
> > > + */
> > > +#define EXPORT_MACRO_SYMBOL(x) EXPORT_SYMBOL(x)    
> > 
> > Seems okay, but what about just calling it EXPORT_SYMBOL?  
> 
> 
> Actually, this doesn't work. There's some magic going on it
> Makefile.build in the scripts directory that causes this to fail.
> 
> I have another patch I'll be sending on Monday that fixes this.

Yes it's grepping for EXPORT_SYMBOL_* I think. If you need to
create a new name, EXPORT_SYMBOL prefix would be preferred. But
yeah if you make the standard macro do macro expansion, it
should just work, no?