From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941124AbcJXTYf (ORCPT ); Mon, 24 Oct 2016 15:24:35 -0400 Received: from up.free-electrons.com ([163.172.77.33]:52782 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S941018AbcJXTDC (ORCPT ); Mon, 24 Oct 2016 15:03:02 -0400 Date: Mon, 24 Oct 2016 16:40:14 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: dri-devel , linux-arm-kernel , linux-kernel , Daniel Vetter , David Airlie Subject: Re: [PATCH] drm/sun4i: Add a few formats Message-ID: <20161024144014.occkqw2v5c2ghx4w@lukather> References: <20161018084614.2443-1-maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h4ce4emxgymrfg3z" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --h4ce4emxgymrfg3z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Oct 21, 2016 at 11:15:32AM +0800, Chen-Yu Tsai wrote: > On Tue, Oct 18, 2016 at 4:46 PM, Maxime Ripard > wrote: > > The planes can do more than what was previously exposed. Add support for > > them. > > > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/sun4i/sun4i_backend.c | 20 ++++++++++++++++++++ > > drivers/gpu/drm/sun4i/sun4i_layer.c | 6 ++++++ > > 2 files changed, 26 insertions(+) > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/su= n4i/sun4i_backend.c > > index afb7ddf660ef..b184a476a480 100644 > > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c > > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c > > @@ -96,6 +96,22 @@ static int sun4i_backend_drm_format_to_layer(struct = drm_plane *plane, > > *mode =3D SUN4I_BACKEND_LAY_FBFMT_ARGB8888; > > break; > > > > + case DRM_FORMAT_ARGB4444: > > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_ARGB4444; > > + break; > > + > > + case DRM_FORMAT_ARGB1555: > > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_ARGB1555; > > + break; > > + > > + case DRM_FORMAT_RGBA5551: > > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_RGBA5551; > > + break; > > + > > + case DRM_FORMAT_RGBA4444: > > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_RGBA4444; >=20 > The A20 manual only lists ARGB4444, not RGBA4444. There might be > some discrepancy here. We can deal with them Hmm, yes, that's weird. But I guess this would be part of porting it to the A20. > Also there are some more formats missing from the list, could you > add them as well? Which one do you refer to? > > + break; > > + > > case DRM_FORMAT_XRGB8888: > > *mode =3D SUN4I_BACKEND_LAY_FBFMT_XRGB8888; > > break; > > @@ -104,6 +120,10 @@ static int sun4i_backend_drm_format_to_layer(struc= t drm_plane *plane, > > *mode =3D SUN4I_BACKEND_LAY_FBFMT_RGB888; > > break; > > > > + case DRM_FORMAT_RGB565: > > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_RGB565; > > + break; > > + > > default: > > return -EINVAL; > > } > > diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4= i/sun4i_layer.c > > index f0035bf5efea..5d53c977bca5 100644 > > --- a/drivers/gpu/drm/sun4i/sun4i_layer.c > > +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c > > @@ -73,12 +73,18 @@ static const struct drm_plane_funcs sun4i_backend_l= ayer_funcs =3D { > > static const uint32_t sun4i_backend_layer_formats_primary[] =3D { > > DRM_FORMAT_ARGB8888, > > DRM_FORMAT_RGB888, > > + DRM_FORMAT_RGB565, > > DRM_FORMAT_XRGB8888, > > }; > > > > static const uint32_t sun4i_backend_layer_formats_overlay[] =3D { > > DRM_FORMAT_ARGB8888, > > + DRM_FORMAT_ARGB4444, > > + DRM_FORMAT_ARGB1555, > > + DRM_FORMAT_RGBA5551, > > + DRM_FORMAT_RGBA4444, > > DRM_FORMAT_RGB888, > > + DRM_FORMAT_RGB565, > > DRM_FORMAT_XRGB8888, >=20 > Could you explain in the commit log why these 2 aren't the same? Yep, I will. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --h4ce4emxgymrfg3z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYDh1FAAoJEBx+YmzsjxAgU0cP/REP7lwinCTn9SNJQuzo/Xcn Dbizg7lQLGi+xAsj23G/z3OgMRBPifRKLGjirtwghSc60a5vXE7agffAQWkwRAe+ XmbXBDR8eS49CdMd4TQxvbIpmh0ljFr1Z0BqjEYs7I/48SG5AbLaABWJDqlYZFpA Lzj2J74fGD7cfHfAqwN38lkvuHBwlB7stPi3c8CN8aaIiMZelyvFsSvtFtg3hN4r 9naHGbZZ1aHeEHM5tLejSy80piJ40jay8vOn0bAsvFon0O8kEBRacmy1Nr6onA89 muG4pzuMuu6g8zpczU4WrRQ0jJJra27KqHzT2O0dd8l+e0nzHpaujmgRg1YwzbNb +c7OQ77O9fLmCoEaH8+Hu2xjCJu2q6zhenOImucxvf4tNR0Sm4zBRlwX4/pYtg4r sozZeMaLzkM0k9CbbGrXBrMhqemMAscEcoSXi9GiSCrkXTcqUb5TFaH/ZlnBj9j1 2aNcf97bhfpV/wiVVLPVT1NzOb/gHVbO8vwbwq4+sK0xU6iBe7leXsk1+Nyts9dO KKIiR0ZBad08w1NpJBEgcadzKTSlCIlIgx3ZJPuBJP6MuhPG90cNiz/++ORh59Pd cBzudyPK53dlezWlN9K4jet0m2LpdgYaYrwTVV9R5GoHtZNBmWIDZ2NuKjNhDV3y YWbCfy09ct4GKj+H812H =4uUu -----END PGP SIGNATURE----- --h4ce4emxgymrfg3z--