From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941376AbcJXTuf (ORCPT ); Mon, 24 Oct 2016 15:50:35 -0400 Received: from smtprelay0168.hostedemail.com ([216.40.44.168]:47424 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S938905AbcJXTud (ORCPT ); Mon, 24 Oct 2016 15:50:33 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1543:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2899:3138:3139:3140:3141:3142:3354:3622:3865:3867:3872:4321:4605:5007:6261:7774:7875:10004:10400:10450:10455:10848:10967:11026:11232:11657:11658:11914:12043:12438:12555:12740:12760:12986:13439:14096:14097:14181:14659:14721:19904:19999:21080:21451:30054:30056:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: town04_5b871fd5d0d36 X-Filterd-Recvd-Size: 4830 Date: Mon, 24 Oct 2016 15:50:27 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Shuah Khan , linux-kernel@vger.kernel.org, Ingo Molnar , Namhyung Kim , Tom Zanussi , linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/5] selftests: ftrace: Fix test cases to enable tracing Message-ID: <20161024155027.5dd9674a@gandalf.local.home> In-Reply-To: <147685282642.8760.554191165644931816.stgit@devbox> References: <147685280526.8760.8021110184607782896.stgit@devbox> <147685282642.8760.554191165644931816.stgit@devbox> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Oct 2016 13:53:46 +0900 Masami Hiramatsu wrote: > Fix some test cases to enable tracing before starting > trace test. This can avoid false-positive failure when > previous testcase fails while disabling tracing. I wonder if this would be better to do the enabling from the ftracetest script instead. Then the tests would need to worry about it. -- Steve > > Signed-off-by: Masami Hiramatsu > --- > .../selftests/ftrace/test.d/event/event-enable.tc | 1 + > .../selftests/ftrace/test.d/event/event-pid.tc | 1 + > .../ftrace/test.d/event/subsystem-enable.tc | 1 + > .../ftrace/test.d/event/toplevel-enable.tc | 1 + > .../ftrace/test.d/ftrace/func_profiler.tc | 1 + > .../ftrace/test.d/kprobe/kprobe_ftrace.tc | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > index 87eb9d6..ee7ea0a 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > @@ -23,6 +23,7 @@ fi > > reset_tracer > do_reset > +enable_tracing > > echo 'sched:sched_switch' > set_event > > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-pid.tc b/tools/testing/selftests/ftrace/test.d/event/event-pid.tc > index d4ab27b..1477e5e 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/event-pid.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/event-pid.tc > @@ -30,6 +30,7 @@ fi > > reset_tracer > do_reset > +enable_tracing > > echo 1 > events/sched/sched_switch/enable > > diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > index ced27ef..f4a64f9 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > @@ -23,6 +23,7 @@ fi > > reset_tracer > do_reset > +enable_tracing > > echo 'sched:*' > set_event > > diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > index 0bb5df3..037a82e 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > @@ -23,6 +23,7 @@ fi > > reset_tracer > do_reset > +enable_tracing > > echo '*:*' > set_event > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc > index 7808336..d10d6e0 100644 > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc > @@ -36,6 +36,7 @@ fail() { # mesg > > echo "Testing function tracer with profiler:" > echo "enable function tracer" > +enable_tracing > echo function > current_tracer > echo "enable profiler" > echo 1 > function_profile_enabled > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc > index d6f2f49..bdbd385 100644 > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc > @@ -10,6 +10,7 @@ echo _do_fork > set_ftrace_filter > echo 0 > events/enable > echo > kprobe_events > echo 'p:testprobe _do_fork' > kprobe_events > +enable_tracing > > # kprobe on / ftrace off > echo 1 > events/kprobes/testprobe/enable