From: Tejun Heo <tj@kernel.org>
To: Roman Pen <roman.penyaev@profitbricks.com>
Cc: Andy Lutomirski <luto@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] workqueue: ignore dead tasks in a workqueue sleep hook
Date: Mon, 24 Oct 2016 16:27:28 -0400 [thread overview]
Message-ID: <20161024202728.GC32050@htj.duckdns.org> (raw)
In-Reply-To: <20161024160814.3126-2-roman.penyaev@profitbricks.com>
Hello,
On Mon, Oct 24, 2016 at 06:08:14PM +0200, Roman Pen wrote:
> If panic_on_oops is not set and oops happens inside workqueue kthread,
> kernel kills this kthread. Current patch fixes recursive GPF which
> happens when wq_worker_sleeping() function unconditionally accesses
> the NULL kthread->vfork_done ptr trhu kthread_data() -> to_kthread().
Other than the pointed out style issues, looks good to me. If you
send an updated version, I'll route it through wq/for-4.9-fixes.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-10-24 20:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 16:08 [PATCH v2 1/2] kthread: allocate kthread structure using kmalloc Roman Pen
2016-10-24 16:08 ` [PATCH v2 2/2] workqueue: ignore dead tasks in a workqueue sleep hook Roman Pen
2016-10-24 16:40 ` Peter Zijlstra
2016-10-24 19:09 ` Roman Penyaev
2016-10-24 20:27 ` Tejun Heo [this message]
2016-10-24 16:42 ` [PATCH v2 1/2] kthread: allocate kthread structure using kmalloc Peter Zijlstra
2016-10-24 19:10 ` Roman Penyaev
2016-10-24 17:08 ` Andy Lutomirski
2016-10-24 19:37 ` Roman Penyaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024202728.GC32050@htj.duckdns.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=roman.penyaev@profitbricks.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome