From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941693AbcJYKf7 (ORCPT ); Tue, 25 Oct 2016 06:35:59 -0400 Received: from mga02.intel.com ([134.134.136.20]:37155 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933825AbcJYKf5 (ORCPT ); Tue, 25 Oct 2016 06:35:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,545,1473145200"; d="scan'208";a="893695175" Date: Tue, 25 Oct 2016 13:35:53 +0300 From: Mika Westerberg To: Linus Walleij Cc: Christian Steiner , "linux-kernel@vger.kernel.org" Subject: Re: pinctrl_cherryview: massive error messages (handle_bad_irq) Message-ID: <20161025103553.GH1476@lahna.fi.intel.com> References: <20161019192222.GQ1722@lahna.fi.intel.com> <20161020100801.GV1722@lahna.fi.intel.com> <20161024081417.GB24289@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2016 at 11:26:48AM +0200, Linus Walleij wrote: > On Mon, Oct 24, 2016 at 10:14 AM, Mika Westerberg > wrote: > > > It is possible to detect the BIOS version using DMI strings and issue a > > warning in the driver, if that's what you mean, but currently we don't > > do that. > > I was more thinking about detecting the old BIOS and if that > is present, mask off the interrupts on the resume path or something, > as it is probably a bigger problem to see the warnings than to > loose these settings. > > Possibly also add a warning at probe() like you describe. I think we can do masking of these IRQs (0..community->nirqs-1) unconditionally in probe() because those should belong to the GPIO driver as far as I understand. But I need to double check that from the spec.