From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935725AbcJZWKB (ORCPT ); Wed, 26 Oct 2016 18:10:01 -0400 Received: from up.free-electrons.com ([163.172.77.33]:53458 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755280AbcJZWJQ (ORCPT ); Wed, 26 Oct 2016 18:09:16 -0400 Date: Tue, 25 Oct 2016 12:43:21 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Kishon Vijay Abraham I , Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 1/3] phy: sun4i: check PHY id when poking unknown bit of pmu Message-ID: <20161025104321.ux2kmqr6rws2c65p@lukather> References: <20161024035930.20274-1-icenowy@aosc.xyz> <20161024082802.ev72szwmuqba5ll4@lukather> <1773661477366364@web4j.yandex.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="plxtan3i75fdpj4k" Content-Disposition: inline In-Reply-To: <1773661477366364@web4j.yandex.ru> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --plxtan3i75fdpj4k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Oct 25, 2016 at 11:32:44AM +0800, Icenowy Zheng wrote: >=20 >=20 > > On Mon, Oct 24, 2016 at 11:59:30AM +0800, Icenowy Zheng wrote: > >=20 > >> Allwinner SoC's PHY 0, when used as OTG controller, have no pmu part. > >> The code that poke some unknown bit of PMU for H3/A64 didn't check > >> the PHY, and will cause kernel oops when PHY 0 is used. > >> > >> Fixes: b3e0d141ca9f (phy: sun4i: add support for A64 usb phy) > >> > >> Signed-off-by: Icenowy Zheng > >=20 > > Cc'ing stable would be nice. >=20 > Yes... As it's also used by H3... >=20 > >=20 > > Apart from that, Acked-by: Maxime Ripard >=20 > If I change it to check whether phy->pmu is null, will you keep the ACK? Yep, thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --plxtan3i75fdpj4k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYDzdJAAoJEBx+YmzsjxAgv1YQAJvJIjriMkNHRf1hMZact1rh U2eL6C6dgWYYJTaCeDiwKjM+VJtjN1F2Ucu37xPzFf7z37TCPYyRhOsNKkku8uDy C4wOT+Q/JJqPsVNcqXyY8B0JKS77nhmt5l1g1eAbJwTGCCwsEA1hHMR6ve4ARFwJ N0QiWFWGvnygWHqn1l4TI38UDUB1NBnYNLwxrG/8mdN6j+xwz/pbeX3TRHp4uaf1 jlt2aLhTb+IZ3Sr+p2YPqwWVbR7DkIeHb7IRwswDU6ZgjcRvwEpyHkFJ8/XWeIpD m+al2JHdvF/GR9xEymsC4J/elkkIh1gshVIs0hDqGt6S9o1yYYoaS8y/IObHbI09 +jOVDYeRlrmeKM+mz4oNxhGocg76MnXhgtFOTsGu3+M3K+10FiMrYGOT0i28GWT7 efwDTnZ/wQrNVxmVdpUB61ATcEHc0FKlCaL0TDd13Hmq91OVIW5xnRFPRy1TnJn0 zjiwq3tcbKUUW1/nCwPPePzkcfyAcvhvoVO04svtZAznJlGquvnTpl0DuiJYgtkW 8uD8tEhwn7Ihhu7Pl9rGCf3GjRw4pNt5ZAFWFnEyudjbjzafxxNo0JzyqaavQLri IEfMv0p/hW3eHnif0UA23mPUTzV50N5VSN0PHHJxafcMFy0mLAAAAFKnQ2QvjSb1 r0njpdtYJF8ii1kxg3bg =OSHe -----END PGP SIGNATURE----- --plxtan3i75fdpj4k--