From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Peter Ujfalusi" <peter.ujfalusi@ti.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>,
"Russell King" <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, letux-kernel@openphoenux.org,
linux-kernel@vger.kernel.org, ldewangan@nvidia.com,
kernel@pyra-handheld.com, marek@goldelico.com,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection
Date: Tue, 25 Oct 2016 10:34:11 -0700 [thread overview]
Message-ID: <20161025173411.36uop63p2wzv3gij@atomide.com> (raw)
In-Reply-To: <7F106936-5748-432F-B602-59B890D5396A@goldelico.com>
* H. Nikolaus Schaller <hns@goldelico.com> [161025 10:20]:
>
> > Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi <peter.ujfalusi@ti.com>:
> >
> > On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote:
> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> >> ---
> >> arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
> >> index b04adee..91456b4 100644
> >> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> >> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> >> @@ -124,6 +124,7 @@
> >> compatible = "ti,abe-twl6040";
> >> ti,model = "omap5-uevm";
> >>
> >> + ti,jack_detection;
> >
> > ti,jack-detection
>
> Hm. Looks as if we have found another bug:
> which one is correct?
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289
>
> Should I add another patch?
We have parts of omap-abe-twl6040.txt, the driver and omap4-sdp.dts all
using ti,jack-detection. So omap-abe-twl6040.txt is wrong for the use
of ti,jack_detection.
Regards,
Tony
prev parent reply other threads:[~2016-10-25 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 16:48 [PATCH v2 0/2] DT Fixes for OMAP5 boards H. Nikolaus Schaller
2016-10-25 16:48 ` [PATCH v2 1/2] dts: omap5: baord-common: add phandle to reference Palmas gpadc H. Nikolaus Schaller
2016-10-25 16:48 ` [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection H. Nikolaus Schaller
2016-10-25 16:51 ` Peter Ujfalusi
2016-10-25 17:10 ` Tony Lindgren
2016-10-25 17:18 ` H. Nikolaus Schaller
2016-10-25 17:34 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025173411.36uop63p2wzv3gij@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hns@goldelico.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pyra-handheld.com \
--cc=ldewangan@nvidia.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@armlinux.org.uk \
--cc=marek@goldelico.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®