From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941860AbcJYVYX (ORCPT ); Tue, 25 Oct 2016 17:24:23 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:62491 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbcJYVYV (ORCPT ); Tue, 25 Oct 2016 17:24:21 -0400 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Oleg Drokin , Patrick Farrell , lustre-devel@lists.lustre.org, Bobi Jam , James Simmons , Olaf Weber , James Simmons , Jinshan Xiong , "John L . Hammond" , Liang Zhen , Arnd Bergmann , Andreas Dilger , Bobi Jam , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] staging: lustre: restore initialization of return code Date: Tue, 25 Oct 2016 23:22:31 +0200 Message-Id: <20161025212310.2346367-2-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20161025212310.2346367-1-arnd@arndb.de> References: <20161025212310.2346367-1-arnd@arndb.de> X-Provags-ID: V03:K0:CMuGNmgx6T92AcI7uLz2JJOjOwYEqgAeRFwHg6c8RRO/5ZtYzuz E6yIhcUR0znfAUMD118hBVLmYg57sCkPe0pdkhwTc2fXGHwlnGmQ29st3VwueOsOtgd6uh7 QfPxDROHjxpnh36VQlkc96Nyi7oK5Sqg+CylNdudm1Z+EewygOejU0vpcaxbJTnhpT4Sp1p ETwhX+n2dYWbWjyyu08aA== X-UI-Out-Filterresults: notjunk:1;V01:K0:d8utRxb/t6Q=:Z1bWH10HT+xONd+qA9U2kg soRfFbQfjCXEuRpCyCbHJeb6V3Hx0jDYuy292ON6/XhDR+P9cO+2fYNARxN46rPd/8THolcDQ cgAWjDMxDnJyX4TPg5xcyDUrPvgwpnPhchUQzY4C09kNHec9vxTGNFzk789zw3wK4fxdkxHjN IF/ahvh5YA9Btpa7VZ3dZw8d/a1jHqijSsnKnZKzYd+3yqzW64AJVkvxCjZpvdeuoezHnanZW 6zJoYLB/axU1EqCNajllcXypfiZsgCKKEf3ItQMG4EzWDxzEVz6hF/FT1dukbAEpd0w9mLmFe ynVuEnGTwUc71ie+VD1FaHFfAI1tymcrbpOLOsJGULZE2eZsSVmvkdrigsefIZ5RibGUKw2CZ KaaOzhrW0vAUJ7SZGXXDJdj4p3X+wNhWf9MzZbnxK14tmAkr4CyW6G0zk6Rvn3Gj3fi6QMLfD u5aBjxVWPQUupBmFfdUm7Bi7bgfyBWHIVCotXZBJmOFJK0wH5dGvK2YCvgk6qaBofPCgTQXX7 xFaJkXV3kYo9giYhJheJ6UulvdlFgRp2EzqY18ER4e/oGDrlyPW//eTPp6bEmm2ndIa9wrqrJ R0KPbw7MdbWKuZe4a9fSK722RDBussGG3dlv3zsVWEO7Vih7T7k+ZcmoVYB/zXpR+RSjI+ACd 4vrDU58E7DNjYowHVVK01LkEZ3GOc0iQjVO5SXzYKAWL+oUcEjreVbrYQ+z35HTLE2Jo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A recent rework removed the initialization of the successful return code from lov_getstripe: drivers/staging/lustre/lustre/lov/lov_pack.c: In function 'lov_getstripe': drivers/staging/lustre/lustre/lov/lov_pack.c:426:9: error: 'rc' may be used uninitialized in this function [-Werror=maybe-uninitialized] drivers/staging/lustre/lustre/lov/lov_pack.c:313:6: note: 'rc' was declared here This adds it back. Fixes: e10a431b3fd0 ("staging: lustre: lov: move LSM to LOV layer") Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lustre/lov/lov_pack.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c index 17bceadd66f8..ccc1fae35791 100644 --- a/drivers/staging/lustre/lustre/lov/lov_pack.c +++ b/drivers/staging/lustre/lustre/lov/lov_pack.c @@ -418,6 +418,8 @@ int lov_getstripe(struct lov_object *obj, struct lov_stripe_md *lsm, ((struct lov_user_md *)lmmk)->lmm_stripe_count = lum.lmm_stripe_count; if (copy_to_user(lump, lmmk, lmm_size)) rc = -EFAULT; + else + rc = 0; out_free: kvfree(lmmk); -- 2.9.0