From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754914AbcJZMCS (ORCPT ); Wed, 26 Oct 2016 08:02:18 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40187 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932508AbcJZMCR (ORCPT ); Wed, 26 Oct 2016 08:02:17 -0400 Date: Wed, 26 Oct 2016 14:02:06 +0200 From: Cornelia Huck To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, bhaktipriya96@gmail.com, rkrcmar@redhat.com, stable@vger.kernel.org Subject: Re: [PATCH] KVM: fix OOPS on flush_work In-Reply-To: <1477482290-18464-1-git-send-email-pbonzini@redhat.com> References: <1477482290-18464-1-git-send-email-pbonzini@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102612-0040-0000-0000-0000024D7C4B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102612-0041-0000-0000-00002251A63E Message-Id: <20161026140206.73cb1150.cornelia.huck@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-26_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610260210 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Oct 2016 13:44:50 +0200 Paolo Bonzini wrote: > The conversion done by commit 3706feacd007 ("KVM: Remove deprecated > create_singlethread_workqueue") is broken. It flushes a single work > item &irqfd->shutdown instead of all of them, and even worse if there > is no irqfd on the list then you get a NULL pointer dereference. > Revert the virt/kvm/eventfd.c part of that patch; to avoid the > deprecated function, just allocate our own workqueue---it does > not even have to be unbound---with alloc_workqueue. > > Fixes: 3706feacd007 > Cc: stable@vger.kernel.org > Signed-off-by: Paolo Bonzini > --- > virt/kvm/eventfd.c | 22 +++++++++++++++++++--- > virt/kvm/kvm_main.c | 6 ++++++ > 2 files changed, 25 insertions(+), 3 deletions(-) Reviewed-by: Cornelia Huck