From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942402AbcJ0OFH (ORCPT ); Thu, 27 Oct 2016 10:05:07 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:38080 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964895AbcJ0OFB (ORCPT ); Thu, 27 Oct 2016 10:05:01 -0400 Date: Thu, 27 Oct 2016 11:08:34 +0300 From: Sakari Ailus To: Arnd Bergmann Cc: Mauro Carvalho Chehab , Sebastian Reichel , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] [media] smiapp: make PM functions as __maybe_unused Message-ID: <20161027080834.GU9460@valkosipuli.retiisi.org.uk> References: <20161026203814.1904690-1-arnd@arndb.de> <20161027072818.GQ9460@valkosipuli.retiisi.org.uk> <3736433.WSCIHGPKQU@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3736433.WSCIHGPKQU@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Thu, Oct 27, 2016 at 09:43:16AM +0200, Arnd Bergmann wrote: > On Thursday, October 27, 2016 10:28:18 AM CEST Sakari Ailus wrote: > > > > On Wed, Oct 26, 2016 at 10:38:01PM +0200, Arnd Bergmann wrote: > > > The rework of the PM support has caused two functions to > > > be orphaned when CONFIG_PM is disabled: > > > > > > media/i2c/smiapp/smiapp-core.c:1352:12: error: 'smiapp_power_off' defined but not used [-Werror=unused-function] > > > media/i2c/smiapp/smiapp-core.c:1206:12: error: 'smiapp_power_on' defined but not used [-Werror=unused-function] > > > > > > This changes all four PM entry points to __maybe_unused and > > > removes the #ifdef markers for consistency. This avoids the > > > warnings even when something changes again. > > > > > > Fixes: cbba45d43631 ("[media] smiapp: Use runtime PM") > > > Signed-off-by: Arnd Bergmann > > > > The power-on sequence is in fact mandatory as it involves writing the > > initial configuration to the sensor as well. > > > > Instead, I believe the correct fix is to make the driver depend on > > CONFIG_PM. > > (adding linux-pm list) > > That would be a rather unusual dependency, though it's possible that > a lot of drivers in fact need it but never listed this explictly in > Kconfig. > > What do other drivers do that need to have their runtime_resume > function called at probe time when CONFIG_PM is disabled? That's certainly possible as well. V4L2 sub-device core operation s_power() no longer works (as it now uses runtime PM) but I don't think that's an issue if PM is disabled anyway --- we should really get rid of that in most drivers. I can submit a patch. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk