From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034041AbcJ0O1N (ORCPT ); Thu, 27 Oct 2016 10:27:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45652 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933635AbcJ0O1K (ORCPT ); Thu, 27 Oct 2016 10:27:10 -0400 Date: Thu, 27 Oct 2016 08:10:58 -0500 From: Josh Poimboeuf To: Ingo Molnar Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] x86/unwind: ensure stack grows down Message-ID: <20161027131058.tpdffwlqipv7pcd6@treble> References: <65e1ac5a17bd20d43c21d400ea2fcd84e6d09e78.1477496147.git.jpoimboe@redhat.com> <20161027063010.GA3884@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161027063010.GA3884@gmail.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 27 Oct 2016 13:10:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a sanity check to ensure the stack only grows down, and print a warning if the check fails. Signed-off-by: Josh Poimboeuf --- arch/x86/kernel/unwind_frame.c | 34 ++++++++++++++++++++++++++++++---- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/unwind_frame.c b/arch/x86/kernel/unwind_frame.c index 5639db6..fe4d387 100644 --- a/arch/x86/kernel/unwind_frame.c +++ b/arch/x86/kernel/unwind_frame.c @@ -32,6 +32,15 @@ unsigned long unwind_get_return_address(struct unwind_state *state) } EXPORT_SYMBOL_GPL(unwind_get_return_address); +static size_t regs_size(struct pt_regs *regs) +{ + /* x86_32 regs from kernel mode are two words shorter */ + if (IS_ENABLED(CONFIG_X86_32) && !user_mode(regs)) + return sizeof(*regs) - 2*sizeof(long); + + return sizeof(*regs); +} + static bool is_last_task_frame(struct unwind_state *state) { unsigned long bp = (unsigned long)state->bp; @@ -79,6 +88,7 @@ bool unwind_next_frame(struct unwind_state *state) struct pt_regs *regs; unsigned long *next_bp, *next_frame; size_t next_len; + enum stack_type prev_type = state->stack_info.type; if (unwind_done(state)) return false; @@ -142,6 +152,15 @@ bool unwind_next_frame(struct unwind_state *state) goto bad_address; } + /* Make sure it only unwinds up and doesn't overlap the last frame: */ + if (state->stack_info.type == prev_type) { + if (state->regs && (void *)next_frame < (void *)state->regs + regs_size(state->regs)) + goto bad_address; + + if (state->bp && (void *)next_frame < (void *)state->bp + FRAME_HEADER_SIZE) + goto bad_address; + } + /* move to the next frame */ if (regs) { state->regs = regs; @@ -154,10 +173,17 @@ bool unwind_next_frame(struct unwind_state *state) return true; bad_address: - printk_deferred_once(KERN_WARNING - "WARNING: kernel stack frame pointer at %p in %s:%d has bad value %p\n", - state->bp, state->task->comm, - state->task->pid, next_bp); + if (state->regs) { + printk_deferred_once(KERN_WARNING + "WARNING: kernel stack regs at %p in %s:%d has bad 'bp' value %p\n", + state->regs, state->task->comm, + state->task->pid, next_frame); + } else { + printk_deferred_once(KERN_WARNING + "WARNING: kernel stack frame pointer at %p in %s:%d has bad value %p\n", + state->bp, state->task->comm, + state->task->pid, next_frame); + } the_end: state->stack_info.type = STACK_TYPE_UNKNOWN; return false; -- 2.7.4