From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034061AbcJ0OfT (ORCPT ); Thu, 27 Oct 2016 10:35:19 -0400 Received: from up.free-electrons.com ([163.172.77.33]:39692 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S941832AbcJ0OfI (ORCPT ); Thu, 27 Oct 2016 10:35:08 -0400 Date: Thu, 27 Oct 2016 16:35:05 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: dri-devel , linux-arm-kernel , linux-kernel , Daniel Vetter , David Airlie Subject: Re: [PATCH] drm/sun4i: Add a few formats Message-ID: <20161027143505.rblgbz5uqjynrtjk@lukather> References: <20161018084614.2443-1-maxime.ripard@free-electrons.com> <20161024144014.occkqw2v5c2ghx4w@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4xyodfpvqdler4df" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --4xyodfpvqdler4df Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Oct 25, 2016 at 08:42:26AM +0800, Chen-Yu Tsai wrote: > On Mon, Oct 24, 2016 at 10:40 PM, Maxime Ripard > wrote: > > Hi, > > > > On Fri, Oct 21, 2016 at 11:15:32AM +0800, Chen-Yu Tsai wrote: > >> On Tue, Oct 18, 2016 at 4:46 PM, Maxime Ripard > >> wrote: > >> > The planes can do more than what was previously exposed. Add support= for > >> > them. > >> > > >> > Signed-off-by: Maxime Ripard > >> > --- > >> > drivers/gpu/drm/sun4i/sun4i_backend.c | 20 ++++++++++++++++++++ > >> > drivers/gpu/drm/sun4i/sun4i_layer.c | 6 ++++++ > >> > 2 files changed, 26 insertions(+) > >> > > >> > diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm= /sun4i/sun4i_backend.c > >> > index afb7ddf660ef..b184a476a480 100644 > >> > --- a/drivers/gpu/drm/sun4i/sun4i_backend.c > >> > +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c > >> > @@ -96,6 +96,22 @@ static int sun4i_backend_drm_format_to_layer(stru= ct drm_plane *plane, > >> > *mode =3D SUN4I_BACKEND_LAY_FBFMT_ARGB8888; > >> > break; > >> > > >> > + case DRM_FORMAT_ARGB4444: > >> > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_ARGB4444; > >> > + break; > >> > + > >> > + case DRM_FORMAT_ARGB1555: > >> > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_ARGB1555; > >> > + break; > >> > + > >> > + case DRM_FORMAT_RGBA5551: > >> > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_RGBA5551; > >> > + break; > >> > + > >> > + case DRM_FORMAT_RGBA4444: > >> > + *mode =3D SUN4I_BACKEND_LAY_FBFMT_RGBA4444; > >> > >> The A20 manual only lists ARGB4444, not RGBA4444. There might be > >> some discrepancy here. We can deal with them > > > > Hmm, yes, that's weird. But I guess this would be part of porting it > > to the A20. > > > >> Also there are some more formats missing from the list, could you > >> add them as well? > > > > Which one do you refer to? >=20 > RGB556 and RGB655. These formats are not supported by Linux yet though. Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --4xyodfpvqdler4df Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYEhCUAAoJEBx+YmzsjxAgjpoQAI+Oior5X8kjzGNDmVTVjns8 +jN6kdLDiqNlDXrzWzksh8cq9JlVqe+4sv0UDEWIRG9tJ+yejQfcKFtRISEmnNYd 2gwoNsNg/nn0VIP/3LWACeJpy6gvESUJRlwQB3BN3buSOYkvr8prmnGQW27JBXil SaRMDzJzH2GBFg6nQdTJlfPwFczyUSNUzTHVC8i+zZOcNcA6dH4Eu30EE8CK4Tqn cSNo8+XCyNGIqdmFvggSWziNF7hTLnmsyJBKt9OX4tf4ISzJ7n2e43DFP3xUvYHB YCg6RYlNLSlPANgC3jOIamcEI9ZmS1k37LTm56/tLrOdFYn5xtIwBk+mtEJzVuEh p2QEWjCuVqwVUwXnIzZHkt6iRrGi2h3HJ3KkwLm4MN36+u06wXv1RUNjHbcmdZnj qMjWas5gyzcu5Km60mV0sgJyEmqOx0m10byMMfmtONOR8Hzr6lhYGQJWYSc1E+zR xakiQohQhuh4kXLEe8mcdWrNO/sbppTf0HCNOm7wLf6PcKcz09G6J6kM35volyyi KoR1Ybm4jzE/u2dpmYwWYStaT21LOx6JvTWnaxq/+SXbvZVz4vmxJLZZsKIjbev1 x2mkCtnoSUi/4xPu8YPGNjYPH4cGaLNdPGN6c2QQgrcH+q3lgN0nXw0KnnGi49Zo ESFC+8gXFBe3FmqrCGL6 =ARrS -----END PGP SIGNATURE----- --4xyodfpvqdler4df--