From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964983AbcJ0SVF (ORCPT ); Thu, 27 Oct 2016 14:21:05 -0400 Received: from anholt.net ([50.246.234.109]:35490 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751724AbcJ0SU7 (ORCPT ); Thu, 27 Oct 2016 14:20:59 -0400 From: Eric Anholt To: Thomas Gleixner Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , bcm-kernel-feedback-list@broadcom.com, Jason Cooper , Marc Zyngier , Phil Elwell , Eric Anholt Subject: [PATCH v2] irqchip/bcm2836: Prevent spurious interrupts Date: Thu, 27 Oct 2016 11:20:38 -0700 Message-Id: <20161027182038.11312-1-eric@anholt.net> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Phil Elwell The old arch-specific IRQ macros included a dsb to ensure the write to clear the mailbox interrupt completed before returning from the interrupt. The BCM2836 irqchip driver needs the same precaution to avoid spurious interrupts. Signed-off-by: Phil Elwell Signed-off-by: Eric Anholt --- drivers/irqchip/irq-bcm2836.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index d96b2c947e74..93e3f7660c42 100644 --- a/drivers/irqchip/irq-bcm2836.c +++ b/drivers/irqchip/irq-bcm2836.c @@ -175,6 +175,7 @@ __exception_irq_entry bcm2836_arm_irqchip_handle_irq(struct pt_regs *regs) u32 ipi = ffs(mbox_val) - 1; writel(1 << ipi, mailbox0); + dsb(sy); handle_IPI(ipi, regs); #endif } else if (stat) { -- 2.9.3