From: Mark Brown <broonie@kernel.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Alexandru Gagniuc <mr.nuke.me@gmail.com>,
wens@csie.org, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size
Date: Thu, 27 Oct 2016 23:47:12 +0100 [thread overview]
Message-ID: <20161027224712.GY25322@sirena.org.uk> (raw)
In-Reply-To: <20161027212727.leqg3gvwhd3u64er@lukather>
[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]
On Thu, Oct 27, 2016 at 11:27:27PM +0200, Maxime Ripard wrote:
> On Thu, Oct 27, 2016 at 12:14:19PM +0100, Mark Brown wrote:
> > but since I'm not turning up anything with this subject line I've no
> > idea what that might have been (and that's very concerning in itself
> > given that this is apparently v7...).
> v4 was here: https://patchwork.kernel.org/patch/3893371/
> v5: https://patchwork.kernel.org/patch/5455381/
> v6: https://patchwork.kernel.org/patch/6975871/
> So basically, I really have no idea why, but it really seems like it
> was just falling through the cracks, repeatedly (I'm not puting the
> blame on anyone though, it just happened). Maybe it was just because
> of the lack of comments :)
Oh, those subject lines were all starting ARM: rather than spi: -
there's a good chance I didn't look at the patches if I was busy
thinking they were changes for arch/arm rather than the SPI driver.
> > I'm also concerned that there isn't a version of this for sun6i,
> > it's going to make all the cut'n'pasting between the two drivers
> > harder if we make changes in one and not the other.
> I think I'll give reg_field a shot though, and try to merge the sun6i
> driver into this one and see the results. If it can help your
> decision.
It would definitely be nice given the level of duplication.
> > If the concern from the previous reviews to do with not using DMA is
> > there some reason it's hard to do DMA?
> I think just like Alexandru that it is orthogonal. But to really
> answer, no, it's not difficult. There's just been some fundamental
> disagreement on whether DMA was supposed to be optional or not that
> stalled everything I guess.
Oh, I seem to remember some patches adding DMA support that were doing
some strange special snowflake thing with ignoring errors now that I
think about it but that's not this one... why did nobody ever follow up
on those?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-10-27 22:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 7:00 Alexandru Gagniuc
2016-10-26 7:00 ` [PATCH] " Alexandru Gagniuc
2016-10-29 18:12 ` Applied "spi: sun4i: Allow transfers larger than FIFO size" to the spi tree Mark Brown
2016-10-26 8:55 ` [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Maxime Ripard
2016-10-27 11:14 ` Mark Brown
2016-10-27 21:27 ` Maxime Ripard
2016-10-27 22:47 ` Mark Brown [this message]
2016-11-02 17:47 ` Maxime Ripard
2016-10-26 10:07 ` Mark Brown
2016-10-26 16:06 ` Alex Gagniuc
2016-10-26 16:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027224712.GY25322@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mr.nuke.me@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®