From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936004AbcJ1ITq (ORCPT ); Fri, 28 Oct 2016 04:19:46 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:52549 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759198AbcJ1ITm (ORCPT ); Fri, 28 Oct 2016 04:19:42 -0400 From: Arnd Bergmann To: Linus Walleij Cc: Laxman Dewangan , Jon Hunter , Arnd Bergmann , Krzysztof Kozlowski , Lee Jones , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pinctrl: max77620: add OF dependency Date: Fri, 28 Oct 2016 10:19:05 +0200 Message-Id: <20161028081923.3238580-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:guWwkKNYEP1+y7XPwsTGdA/fqAnYKH3vCc++E/QeMqba+aZ6qoY z4eATxHNp4ySlpfqg2AXqbUrjvNjdFEdrDSJEo3RGU6t457QBuQ8pB7l38QI6kI+v18z5N6 qDcDy75kZ69o5QdWJ8V2MNc6KzwcQTaz12xkV661LwLYTZAHZbJi3WjWa32hJmFKQD/MLfN t/S0YxCOxTvZAPoYoMKwQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:mElsJujpulw=:uj/84iy+zglD8PK+NAc0Yl LgBUoooC+RD5N8VwJf6h/l6jF6GmRcS1KY7cBc/n7WmACTzSptDq1blihAfwJHsdrxUJkzob4 0Gigv1XLHvQcOv1I7oSJYO1r/lwQqou5PNnhpvTSzgVXkC5nwnE1iMx2DxzSnbTwPVfasUC/n kriItxoyUJhf2EyGRHHgZIUk1pUSfVbQsYAexpHjIF/sPt0asD5E9I2n4YHP8rXQgU1CSFs7z 3R4nl5HngPCv9+1r8SSa4CgnqM5oqNNoxsxj3Y0wh9wJXxyrtgG2xY/5rvuyH3zJfHOBDzmct 4aUQUKlOwCuu1yZS2g0RCwc7gTJGcyGPg0Th814tAAwvfZITbUDhFRDZX5xhfpH08cO0b7dI6 T5Wgm81B3uK4X8+0dwKNvtp9ocpyC2/uD1zIn2a61AzoWQS4wtPSk8uazxp+r2Qw26i8EZxGt O9dx9YOKYLJybdMQeDkObPpWGsi/bT2KdlgK/KBaOebslSPtlVVf+dUQ2eeXkNtk/+zy1iO4L ej9THoLRbzSClu1k/8r3iS1c6sJJsL6VL007V79agMV/O9FYkN4iL9RrL5s0nuzMlFTRMtRvv 3QjJPOkKtzx3Y9Un/5RCL4QC+2AWBZPX7U23Dnp1BiH3yH6Tbeo+R8keezjUwD4TqXfJfLVbX /Ln8wE7npV/7MdgDh+oHxmmEctoprrbZrbWHHMV79VwwaJTk6IQ0vMo/zX63wNya1JrXBSo5Q ixQagGMr/vlA9rdQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drivers using pinconf_generic_params tables cannot be built with CONFIG_OF disabled: drivers/pinctrl/pinctrl-max77620.c:53:44: error: array type has incomplete element type ‘struct pinconf_generic_params’ drivers/pinctrl/pinctrl-max77620.c:55:3: error: field name not in record or union initializer drivers/pinctrl/pinctrl-max77620.c:55:3: note: (near initialization for ‘max77620_cfg_params’) drivers/pinctrl/pinctrl-max77620.c:56:3: error: field name not in record or union initializer This adds a dependency for max77620 to disallow that configuration. Alternatively, we could rework the pinctrl infrastructure to make the configuration valid for compile-testing. Cc: Krzysztof Kozlowski Cc: Lee Jones Fixes: 453943dc8f45 ("mfd: Enable compile testing for max77620 and max77686") Signed-off-by: Arnd Bergmann --- drivers/pinctrl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 801fa8bb05e1..3eea73937ce8 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -223,7 +223,7 @@ config PINCTRL_COH901 config PINCTRL_MAX77620 tristate "MAX77620/MAX20024 Pincontrol support" - depends on MFD_MAX77620 + depends on MFD_MAX77620 && OF select PINMUX select GENERIC_PINCONF help -- 2.9.0