From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759538AbcJ1Qm6 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 12:42:58 -0400
Received: from mail.skyhub.de ([78.46.96.112]:36675 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753083AbcJ1Qm4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 12:42:56 -0400
Date: Fri, 28 Oct 2016 18:42:51 +0200
From: Borislav Petkov <bp@alien8.de>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Ingo Molnar <mingo@kernel.org>, Mike Galbraith <efault@gmx.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v6 2/2] x86/apic: x2apic write eoi msr notrace
Message-ID: <20161028164251.h7344whq3jctvhft@pd.tnic>
References: <1477543122-4908-1-git-send-email-wanpeng.li@hotmail.com>
 <1477543122-4908-3-git-send-email-wanpeng.li@hotmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1477543122-4908-3-git-send-email-wanpeng.li@hotmail.com>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 27, 2016 at 12:38:42PM +0800, Wanpeng Li wrote:

...

> This patch converts x2apic write eoi msr to notrace to avoid the debug 
> codes splash and reverts irq_enter/irq_exit dance to avoid to make a very 
> frequent interrupt slower because of debug code.
> 
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---

...

> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index edbbfc8..d230513 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -308,7 +308,7 @@ static void kvm_register_steal_time(void)
>  
>  static DEFINE_PER_CPU(unsigned long, kvm_apic_eoi) = KVM_PV_EOI_DISABLED;
>  
> -static void kvm_guest_apic_eoi_write(u32 reg, u32 val)
> +notrace static void kvm_guest_apic_eoi_write(u32 reg, u32 val)

WARNING: storage class should be at the beginning of the declaration
#107: FILE: arch/x86/kernel/kvm.c:311:
+notrace static void kvm_guest_apic_eoi_write(u32 reg, u32 val)

Make sure you integrate checkpatch.pl in your patches creating workflow...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.