From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932194AbcJaA6D (ORCPT <rfc822;w@1wt.eu>);
        Sun, 30 Oct 2016 20:58:03 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:38546 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752165AbcJaA6C (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 30 Oct 2016 20:58:02 -0400
Date: Sun, 30 Oct 2016 20:57:55 -0400 (EDT)
Message-Id: <20161030.205755.1198665157526465556.davem@davemloft.net>
To: mlord@pobox.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] r8152: Fix broken RX checksums.
From: David Miller <davem@davemloft.net>
In-Reply-To: <9fb6be7b-95f3-6e59-c0f4-1d6c3357416d@pobox.com>
References: <987cfbab-2b48-e28c-1706-967cb2051d63@pobox.com>
        <9fb6be7b-95f3-6e59-c0f4-1d6c3357416d@pobox.com>
X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 30 Oct 2016 16:58:24 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Mark Lord <mlord@pobox.com>
Date: Sun, 30 Oct 2016 19:28:27 -0400

> The r8152 driver has been broken since (approx) 3.16.xx
> when support was added for hardware RX checksums
> on newer chip versions.  Symptoms include random
> segfaults and silent data corruption over NFS.
> 
> The hardware checksum logig does not work on the VER_02
> dongles I have here when used with a slow embedded system CPU.
> Google reveals others reporting similar issues on Raspberry Pi.
> 
> So, disable hardware RX checksum support for VER_02, and fix
> an obvious coding error for IPV6 checksums in the same function.
> 
> Because this bug results in silent data corruption,
> it is a good candidate for back-porting to -stable >= 3.16.xx.
> 
> Signed-off-by: Mark Lord <mlord@pobox.com>

Applied and queued up for -stable, thanks.