From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755590AbcJ3Xq2 (ORCPT <rfc822;w@1wt.eu>);
        Sun, 30 Oct 2016 19:46:28 -0400
Received: from mail.skyhub.de ([78.46.96.112]:48440 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751497AbcJ3Xq1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 30 Oct 2016 19:46:27 -0400
Date: Mon, 31 Oct 2016 00:46:22 +0100
From: Borislav Petkov <bp@alien8.de>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Mike Galbraith <efault@gmx.de>, Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v6 1/2] x86/msr: Add write msr notrace
Message-ID: <20161030234622.lecmbbz46kljtg7s@pd.tnic>
References: <1477543122-4908-1-git-send-email-wanpeng.li@hotmail.com>
 <1477543122-4908-2-git-send-email-wanpeng.li@hotmail.com>
 <20161028164735.ehgblzeaczsk765a@pd.tnic>
 <CANRm+CxdX1X4yoOsHE-SsfeJ117xMdGjFgtV0ZMmPfxYWNxhwA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CANRm+CxdX1X4yoOsHE-SsfeJ117xMdGjFgtV0ZMmPfxYWNxhwA@mail.gmail.com>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 31, 2016 at 07:30:33AM +0800, Wanpeng Li wrote:
> Other functions like native_write_msr() and native_write_msr_safe()
> etc are also not aligned, so your suggestion maybe result in
> inconsistent.

So align them too, while you're at it.

> > And because we know what those are, you can convert them directly to u32.
> 
> Ditto.

You could convert the rest to u32/u64 in another patch, ontop or if you
don't feel like it, I can take care of it.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.