From: David Miller <davem@davemloft.net>
To: dongli.zhang@oracle.com
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
netdev@vger.kernel.org, boris.ostrovsky@oracle.com,
david.vrabel@citrix.com, jgross@suse.com
Subject: Re: [PATCH 1/1] xen-netfront: do not cast grant table reference to signed short
Date: Mon, 31 Oct 2016 16:06:23 -0400 (EDT) [thread overview]
Message-ID: <20161031.160623.714189344925104774.davem@davemloft.net> (raw)
In-Reply-To: <1477892309-7150-1-git-send-email-dongli.zhang@oracle.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
Date: Mon, 31 Oct 2016 13:38:29 +0800
> While grant reference is of type uint32_t, xen-netfront erroneously casts
> it to signed short in BUG_ON().
>
> This would lead to the xen domU panic during boot-up or migration when it
> is attached with lots of paravirtual devices.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Since this is consistent with how the macros in linux/err.h handle "is
this an error" checks, this change looks good to me.
Applied, thanks.
next prev parent reply other threads:[~2016-10-31 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 5:38 Dongli Zhang
2016-10-31 7:47 ` [Xen-devel] " Jan Beulich
2016-10-31 20:06 ` David Miller [this message]
2016-11-01 4:46 Dongli Zhang
2016-11-01 14:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031.160623.714189344925104774.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=dongli.zhang@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®